Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2-3.0.1-1.fc12.src.rpm Description: UML2 is an EMF-based implementation of the Unified Modeling Language (UML) 2.x OMG metamodel for the Eclipse platform. The objectives of the UML2 component are to provide: * a usable implementation of the UML metamodel to support the development of modeling tools. * a common XMI schema to facilitate interchange of semantic models. * test cases as a means of validating the specification. * validation rules as a means of defining and enforcing levels of compliance.
Good work, Mat. * Package name and version are in accordance with packaging guidelines * SPEC file clean, legible and well-commented * License tag correct, license packaged as %doc * Builds fine in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1821764 * RPMLint happy (a couple of false positives about spelling errors in fc13) * Filelist okay * Provides/Require list ok A few objections: 1.) Why do you check stuff out from CVS? There seem to be a source/sdk bundle available at the downloads page: http://www.eclipse.org/modeling/mdt/downloads/?project=uml2 2.) Please don't pretty-format the Description. It does not always look well in package management front-ends.
(In reply to comment #1) > A few objections: > > 1.) Why do you check stuff out from CVS? There seem to be a source/sdk bundle > available at the downloads page: > http://www.eclipse.org/modeling/mdt/downloads/?project=uml2 Because although the SDK distribution does contain the source plugins, they don't contain enough information in order to build it. The source plugins are there to aid development of plugins that use the plugins in this package (so you can do source level debugging and what have you). Checking out from source control directly gives us everything we need, indeed this is how we'd build the source plugins in the first place. This generally goes for all plugins from the Eclipse project. > > 2.) Please don't pretty-format the Description. It does not always look well in > package management front-ends. Ok, I will reformat the description, that's no problem. Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-uml2-3.0.1-2.fc12.src.rpm
(In reply to comment #2) ... > This generally goes for all plugins from the Eclipse project. Okay, sounds fair enough. Thank you. > Ok, I will reformat the description, that's no problem. Thanks. This itself definitely wouldn't be a problem. As it, along with the source tarballs which were sufficiently explained, was the only complain in some of your other reviews, I'm going to approve them as well. APPROVED
Thanks for the speedy feedback and swift review, Lubomir. New Package CVS Request ======================= Package Name: eclipse-mdt-uml2 Short Description: Implementation of the UML2 OMG metamodel for Eclipse Owners: mbooth Branches: F-12
cvs done.
Built successfully for Rawhide, closing.