Bug 536684 - Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for Eclipse
Summary: Review Request: eclipse-mdt-ocl - Implementation of the OCL OMG metamodel for...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 536683
Blocks: 537451 537452 537652
TreeView+ depends on / blocked
 
Reported: 2009-11-10 22:10 UTC by Mat Booth
Modified: 2009-12-01 20:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-01 20:16:38 UTC
Type: ---
lkundrak: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Mat Booth 2009-11-10 22:10:15 UTC
This package depends eclipse-mdt-uml2, whose review request is bug #536683.

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec
SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-1.fc12.src.rpm

Description:
OCL is an implementation of the Object Constraint Language (OCL) OMG standard
for EMF-based models. The OCL component provides the following capabilities to
support OCL integration:

 * Defines APIs for parsing and evaluating OCL constraints and queries on EMF
   models.
 * Defines an Ecore implementation of the OCL abstract syntax model, including
   support for serialization of parsed OCL expressions.
 * Provides a Visitor API for analyzing/transforming the AST model of OCL
   expressions.
 * Provides an extensibility API for clients to customize the parsing and
   evaluation environments used by the parser.

Comment 1 Lubomir Rintel 2009-11-21 19:09:59 UTC
* Package name and version are in accordance with packaging guidelines
* SPEC file clean, legible and well-commented
* License tag correct, license packaged as %doc
* Local mockbuild with eclipse-mdt-uml2 dragged in succeeded
* RPMLint happy
  * a couple of warnings spelling errors in fc13, all of them false positives
  * warning about symlink target not being in package; ok since it's in dependnecy
* Filelist okay
* Provides/Require list ok

Objections:

1.) Why do you check stuff out from CVS and make up a qualifier? There seem to be a source bundle available at the downloads page:
http://www.eclipse.org/modeling/mdt/downloads/?project=ocl

2.) Please don't pretty-format the Description. It does not always look well in package management front-ends.

3.) Please use build-classpath to get the file name of lpgjavaruntime.jar. Like: 
ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \
    net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar

Comment 2 Mat Booth 2009-11-22 14:11:23 UTC
(In reply to comment #1)
> * Package name and version are in accordance with packaging guidelines
> * SPEC file clean, legible and well-commented
> * License tag correct, license packaged as %doc
> * Local mockbuild with eclipse-mdt-uml2 dragged in succeeded
> * RPMLint happy
>   * a couple of warnings spelling errors in fc13, all of them false positives
>   * warning about symlink target not being in package; ok since it's in
> dependnecy
> * Filelist okay
> * Provides/Require list ok
> 
> Objections:
> 
> 1.) Why do you check stuff out from CVS and make up a qualifier? There seem to
> be a source bundle available at the downloads page:
> http://www.eclipse.org/modeling/mdt/downloads/?project=ocl
> 

See the eclipse-mdt-uml2 review. The qualifier comes from the release tag we use to check the source out of version control - see get-mdt-ocl.sh.

> 2.) Please don't pretty-format the Description. It does not always look well in
> package management front-ends.
> 

Ok, no probs.

> 3.) Please use build-classpath to get the file name of lpgjavaruntime.jar.
> Like: 
> ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \
>     net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar  

Ok, sure.

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec
SRPM URL:
http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-2.fc12.src.rpm

Comment 3 Lubomir Rintel 2009-11-27 12:14:19 UTC
Looks well now.

APPROVED

Comment 4 Mat Booth 2009-11-27 14:05:05 UTC
(In reply to comment #3)
> Looks well now.
> 
> APPROVED  

Nice one, thanks.

New Package CVS Request
=======================
Package Name: eclipse-mdt-ocl
Short Description: Implementation of the OCL OMG metamodel for Eclipse
Owners: mbooth
Branches: F-12

Comment 5 Jason Tibbitts 2009-12-01 18:45:37 UTC
CVS done.

Comment 6 Mat Booth 2009-12-01 20:16:38 UTC
Built successfully for rawhide, closing.


Note You need to log in before you can comment on or make changes to this bug.