This package depends eclipse-mdt-uml2, whose review request is bug #536683. Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-1.fc12.src.rpm Description: OCL is an implementation of the Object Constraint Language (OCL) OMG standard for EMF-based models. The OCL component provides the following capabilities to support OCL integration: * Defines APIs for parsing and evaluating OCL constraints and queries on EMF models. * Defines an Ecore implementation of the OCL abstract syntax model, including support for serialization of parsed OCL expressions. * Provides a Visitor API for analyzing/transforming the AST model of OCL expressions. * Provides an extensibility API for clients to customize the parsing and evaluation environments used by the parser.
* Package name and version are in accordance with packaging guidelines * SPEC file clean, legible and well-commented * License tag correct, license packaged as %doc * Local mockbuild with eclipse-mdt-uml2 dragged in succeeded * RPMLint happy * a couple of warnings spelling errors in fc13, all of them false positives * warning about symlink target not being in package; ok since it's in dependnecy * Filelist okay * Provides/Require list ok Objections: 1.) Why do you check stuff out from CVS and make up a qualifier? There seem to be a source bundle available at the downloads page: http://www.eclipse.org/modeling/mdt/downloads/?project=ocl 2.) Please don't pretty-format the Description. It does not always look well in package management front-ends. 3.) Please use build-classpath to get the file name of lpgjavaruntime.jar. Like: ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \ net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar
(In reply to comment #1) > * Package name and version are in accordance with packaging guidelines > * SPEC file clean, legible and well-commented > * License tag correct, license packaged as %doc > * Local mockbuild with eclipse-mdt-uml2 dragged in succeeded > * RPMLint happy > * a couple of warnings spelling errors in fc13, all of them false positives > * warning about symlink target not being in package; ok since it's in > dependnecy > * Filelist okay > * Provides/Require list ok > > Objections: > > 1.) Why do you check stuff out from CVS and make up a qualifier? There seem to > be a source bundle available at the downloads page: > http://www.eclipse.org/modeling/mdt/downloads/?project=ocl > See the eclipse-mdt-uml2 review. The qualifier comes from the release tag we use to check the source out of version control - see get-mdt-ocl.sh. > 2.) Please don't pretty-format the Description. It does not always look well in > package management front-ends. > Ok, no probs. > 3.) Please use build-classpath to get the file name of lpgjavaruntime.jar. > Like: > ln -s ../../../../../../../$(build-classpath lpgjavaruntime) \ > net.sourceforge.lpg.lpgjavaruntime_1.1.0.jar Ok, sure. Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-mdt-ocl-1.3.0-2.fc12.src.rpm
Looks well now. APPROVED
(In reply to comment #3) > Looks well now. > > APPROVED Nice one, thanks. New Package CVS Request ======================= Package Name: eclipse-mdt-ocl Short Description: Implementation of the OCL OMG metamodel for Eclipse Owners: mbooth Branches: F-12
CVS done.
Built successfully for rawhide, closing.