Bug 536902
| Summary: | quota file size not a multiple of struct gfs2_quota | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Abhijith Das <adas> | |
| Component: | gfs2-utils | Assignee: | Abhijith Das <adas> | |
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | low | |||
| Version: | 5.4 | CC: | bmarzins, edamato, jkortus, kkovachev, lsmid, rpeterso, scooter, swhiteho, uk | |
| Target Milestone: | rc | |||
| Target Release: | 5.5 | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | gfs2-utils-0.1.62-20.el5 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 546455 (view as bug list) | Environment: | ||
| Last Closed: | 2010-03-30 08:53:49 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 546455, 589813 | |||
| Attachments: | ||||
|
Description
Abhijith Das
2009-11-11 18:37:02 UTC
Created attachment 369091 [details] gzipped quota file Another erroneous GFS2 quota file as requested in https://www.redhat.com/archives/linux-cluster/2009-November/msg00090.html Thank you for your attention. Created attachment 375864 [details]
RHEL5 patch - kernel portion of the patch to remove the quota linked list stuff
This is my first bash at fiemap-based reading of the quota file.
This is the kernel part of a 2-part patch set to remove the linked-list implementation of quotas on disk. The linked list was a workaround for listing the sparse quota file, but it was tedious to maintain and made the code complicate as well. Not to mention the annoying warning messages.
This patch rips out the linked-list part from the on disk quota structure and restores it to it's original form prior to the linked-list patch. There is now fiemap support in gfs2 that allows us to read sparse files efficiently.
For this to work correctly, both this kernel patch and the following userland patch to gfs2_quota should be present.
A 'gfs2_quota reset' should not be required for the newer gfs2_quota to work with filesystems that have the linked-list on disk quotas.
Created attachment 375865 [details]
RHEL5 userland patch
Created attachment 377604 [details]
Updated userland patch - Fixes EOF condition where extent was longer than size of file
Created attachment 377612 [details]
missed a spot
Created attachment 377613 [details]
userland upstream patch
Pushed fix in comment #8 to STABLE3 in cluster.git and HEAD of gfs2-utils.git Pushed fix in comment #7 to RHEL55 branch in cluster.git Build 2163188 complete and successful. This is fixed in gfs2-utils-0.1.62-14.el5. Created attachment 397652 [details]
RHEL5.5 userland part 2 patch
This patch fixes an error due to uninitialized fiemap flags. Also, while testing, I found a couple of other issues with boundary conditions where some quotas were not being set properly with "gfs2_quota limit/warn" and not being displayed with "gfs2_quota list". This patch fixes these as well.
Build 2298701 complete and successful. This is fixed in version gfs2-utils-0.1.62-20.el5 *** Bug 568119 has been marked as a duplicate of this bug. *** The utilites no longer produce any warnings nor errors. You may still experience kernel panic during quota reset until bug 569610 is fixed. Marking as verified. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2010-0287.html |