Bug 537454 - Review Request: eclipse-emf-transaction - A model management layer for managing EMF resources
Summary: Review Request: eclipse-emf-transaction - A model management layer for managi...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 537451 537452
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-13 17:13 UTC by Mat Booth
Modified: 2009-12-01 21:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-01 21:23:28 UTC
Type: ---
Embargoed:
lkundrak: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mat Booth 2009-11-13 17:13:24 UTC
This package depends on eclipse-emf-query and eclipse-emf-validation, whose review requests are bug #537451 and bug #537452, respectively.

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-transaction.spec
SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-transaction-1.3.1-1.fc12.src.rpm

Description:
The transaction component provides the following capabilities.

 * Multi-threading - Supports a protocol for clients to read and write EMF
   models on multiple threads.
 * Model Integrity - Semantic integrity is ensured by automatic validation to
   detect invalid changes and semantic procedures to proactively maintain
   correctness of semantic dependencies.
 * Batched Events - Clients are notified of groups of related changes in
   batches, rather than as a stream of EMF notifications. In particular, this
   allows applications to analyze change sets in their entirety.
 * Undo/Redo - For a simplified programming model, the API automatically tracks
   changes applied to models without the need for client code to use EMF edit
   Commands. These changes are encapsulated in transactions/operations that can
   undo and redo themselves.
 * Editing Domain - Support cooperative editing of models by multiple editors/
   applications. EMF resources can be shared amongst different editing domains.
 * Eclipse Workspace - The API provides traceability between EMF resources and
   workspace resources. Multi-threaded access is coordinated via the Eclipse
   jobs API and its integration with the workspace.
 * Eclipse Operations - The API supports the Eclipse operation history as an
   undo stack for undo/redo of resource changes. The API provides a framework
   for undoable operations that automatically capture undo/redo information,
   which can be interleaved on the same history with dependent operations that
   do not modify the EMF model.

Comment 1 Lubomir Rintel 2009-11-21 23:56:38 UTC
* Package name and version are in accordance with packaging guidelines
* SPEC file clean, legible and well-commented
* License tag correct, license packaged as %doc
* RPMLint happy
  * a couple of warnings spelling errors in fc13, all of them false positives
* Filelist okay, for directories it uses and does now it depends on packages
that provide them
* Provides/Require list ok
* Built fine in mock (with dependency repository added)

Objections:

1.) Why do you check stuff out from CVS?

2.) Please don't pretty-format the Description, please use complete sentences.
It does not always look well in package management front-ends.

Comment 2 Lubomir Rintel 2009-11-22 13:34:57 UTC
1.) is answered in bug #536683.
Please re-format the description before importing to CVS!

APPROVED

Comment 3 Mat Booth 2009-11-24 11:03:25 UTC
(In reply to comment #2)
> 1.) is answered in bug #536683.
> Please re-format the description before importing to CVS!
> 

Done:

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-transaction.spec
SRPM URL:
http://mbooth.fedorapeople.org/reviews/eclipse-emf-transaction-1.3.1-2.fc10.src.rpm


> APPROVED  


New Package CVS Request
=======================
Package Name: eclipse-emf-transaction
Short Description: A model management layer for managing EMF resources
Owners: mbooth
Branches: F-12

Comment 4 Kevin Fenzi 2009-11-27 05:31:43 UTC
cvs done.

Comment 5 Mat Booth 2009-12-01 21:23:28 UTC
Built successfully in rawhide, closing.


Note You need to log in before you can comment on or make changes to this bug.