SPEC: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools.spec SRPM: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools-0.7.1-1.src.rpm rpmlint is silent scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1811428
Good: + Name of the package fullfill naming guidelines + Basename of the SPEC file matches with package name + Text in package is written in English + URL shows on proper homepage of the project + Should downloading upstream tarball via spectool -g + Package sources matches with upstream tar ball + License tag exlaim GPLv2 as a valis OSS license + Copyrigh notes on the head of source files matches with license statement of the license tag (md5sum: 8060d39e6f3ea5984cdd643405bfebb1) + Package will build as noarch + Package has no subpackages + Package has proper definition of the BuildRoot + Local build works fine + BuildRoot will be cleaned at beginning of %clean and %install + Rpmlint is silent on source rpm + Rpmlint is silent on binary rpm + Locan install/uninstall works fine + Scratch build works fine on koji + %files stanza has no duplicates entries + Ammount of documentation is small, so we need no doc subpackages + Package has proper Changelog Bad: - Package doesn't contains a verbatin copy ot the license text (No blocker, but please contact upstream to include one into the upstream package) - Please use %global instead of %define - Please use %global rhnroot %{_datadir}/rhn instead of %define rhnroot %{_prefix}/share/rhn - We prefer %defattr(-,root,root,-) - question: Who should ownd %{rhnroot} and %{rhnroot}/certs
> Package doesn't contains a verbatin copy ot the license > text (No blocker, but please contact upstream to include > one into the upstream package) Since I'm part of upstream, I added it there. I also changed license to GPL2 and Python (been notified yesterday in review 491088). > Please use %global instead of %define Done > We prefer %defattr(-,root,root,-) Done. > question: Who should ownd %{rhnroot} rhn-client-tools. Added to Requires. Nice catch. > and %{rhnroot}/certs This package should. Done. Updated SPEC: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools.spec Updated SRPM: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools-0.7.2-1.src.rpm
Good: + Package contains verbain copy of the license text + Could download upstream tarball via spectool -g + Packaged tar ball matches with upstream (md5sum: a918530536865e24b7d9a7f2be956626) + Local build works fine + Scratch build on koji works fine + All files and dirs are owned by a package *** APPROVED ***
New Package CVS Request ======================= Package Name: spacewalk-certs-tools Short Description: Spacewalk SSL Key/Cert Tool Owners: msuchy Branches: F-11, F-12 InitialCC:
cvs done.