Bug 54578 - New python diskcheck has several errors in default config file, script
New python diskcheck has several errors in default config file, script
Status: CLOSED ERRATA
Product: Red Hat Linux
Classification: Retired
Component: diskcheck (Show other bugs)
7.3
i386 Linux
medium Severity high
: ---
: ---
Assigned To: Preston Brown
:
: 54795 57224 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2001-10-12 16:44 EDT by Aleksey Nogin
Modified: 2008-05-01 11:38 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2001-11-07 10:37:55 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
A patch that fixes all these problems with the script (but not the conf file). (2.16 KB, patch)
2001-10-12 17:34 EDT, Aleksey Nogin
no flags Details | Diff

  None (edit)
Description Aleksey Nogin 2001-10-12 16:44:55 EDT
The value of defaultCutoff is never used (it should be).

The diskcheck.conf still has the perl syntax in the examples of setting
the cutoff values.

Lots of redundancies:
 - For some reason the code calls "df" and "df -h" while the "df -h"
   already has all the necessary information.
 - In the
      if (test or ...): ... elseif (test or ...): ...
   construction the second "test or" is unneeded.
 - tempfile is defined and never used.
Comment 1 Aleksey Nogin 2001-10-12 16:59:26 EDT
Also, "-x none" should be added to exclude in diskcheck.conf to exclude "bind"
mounts and "-x tmpfs" to exclude the /dev/shm mount.
Comment 2 Aleksey Nogin 2001-10-12 17:33:12 EDT
And finally, the pct is never converted from a string to a number, so all
comparisons return random results!
Comment 3 Aleksey Nogin 2001-10-12 17:34:50 EDT
Created attachment 34021 [details]
A patch that fixes all these problems with the script (but not the conf file).
Comment 4 Preston Brown 2001-11-07 10:35:38 EST
*** Bug 54795 has been marked as a duplicate of this bug. ***
Comment 5 Preston Brown 2001-11-07 10:38:22 EST
fixed in an upcoming errata.
Comment 6 Harald Hoyer 2001-12-14 08:12:49 EST
*** Bug 57224 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.