Bug 54578
| Summary: | New python diskcheck has several errors in default config file, script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Aleksey Nogin <aleksey> | ||||
| Component: | diskcheck | Assignee: | Preston Brown <pbrown> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7.3 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | i386 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2001-11-07 15:37:55 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Also, "-x none" should be added to exclude in diskcheck.conf to exclude "bind" mounts and "-x tmpfs" to exclude the /dev/shm mount. And finally, the pct is never converted from a string to a number, so all comparisons return random results! Created attachment 34021 [details]
A patch that fixes all these problems with the script (but not the conf file).
*** Bug 54795 has been marked as a duplicate of this bug. *** fixed in an upcoming errata. |
The value of defaultCutoff is never used (it should be). The diskcheck.conf still has the perl syntax in the examples of setting the cutoff values. Lots of redundancies: - For some reason the code calls "df" and "df -h" while the "df -h" already has all the necessary information. - In the if (test or ...): ... elseif (test or ...): ... construction the second "test or" is unneeded. - tempfile is defined and never used.