Bug 545873

Considering that the qemu ROMs appear on a different directory (not /usr/share/gpxe) I suggest making those files just symlinks to the /usr/share/gpxe files:


# the roms supported by qemu will be packaged separatedly
# remove from the main rom list and add them to qemu.list
for fmt in rom ;do 
 for rom in %{qemuroms} ; do
  sed -i -e "/\/${rom}.${fmt}/d" ${fmt}.list
  echo %{_datadir}/pxe-roms/${rom}.zrom >> qemu.${fmt}.list
  mv %{buildroot}/%{_datadir}/%{name}/${rom}.${fmt} %{buildroot}/%{_datadir}/pxe-roms/${rom}.zrom
  ^^^^^^ here


 done
done

# qemu expects this name
mv %{buildroot}/%{_datadir}/pxe-roms/e1000-0x100e.zrom %{buildroot}/%{_datadir}/pxe-roms/e1000-82542.zrom
^^^^^^^^ here



If /usr/share/pxe-roms is qemu-specific (existing only to make qemu find the files it needs), maybe we can call it /usr/share/qemu-pxe-roms/

I gave this some further thoughts, and decided to follow an alternate route here. Instead of using symlinks, I plan on only building the roms we actually need. Remember that by building and shipping the other subpackages, the burden of supporting it would lie on us.

This makes the package deviate a little bit from Fedora version, but I believe it is well justified, specially given the fact that the resulting package is trivially small.

I'll post a follow up soon.

New data:

Spec: http://glommer.fedorapeople.org/gpxe-el5.v2/gpxe.spec

SRPM: http://glommer.fedorapeople.org/gpxe-el5.v2/gpxe-0.9.7-7.el5rhev.src.rpm

This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

Non-blocker comments:

1)
    # Just to be in agreement with etherboot. Gpxe roms are called ".rom",
    # but are compressed by default
    mv bin/$i.rom bin/$i.zrom


You don't need to do that, because we can change KVM to look for .rom files. But not a blocker: we can leave it as-is.

2)
      if [ -e $img ]; then
	   cp -a $img %{buildroot}/%{_datadir}/qemu-pxe-roms/
      fi   

We can use install(1) instead of cp to ensure proper file modes. But Fedora uses 'cp', so it's worth keeping our package closer to Fedora.

The rest looks good to me. It's very close to the Fedora package.


That said, I approve the package.

This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

gpxe was already included. closing.