Bug 548960 - zsh should provide the pathmunge function when loading profile.d scripts from zshrc
Summary: zsh should provide the pathmunge function when loading profile.d scripts from...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: zsh
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: James Antill
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 571549 (view as bug list)
Depends On:
Blocks: 571549
TreeView+ depends on / blocked
 
Reported: 2009-12-19 17:45 UTC by Ville Skyttä
Modified: 2010-06-23 17:51 UTC (History)
4 users (show)

Fixed In Version: zsh-4.3.10-5.fc13
Clone Of:
Environment:
Last Closed: 2010-03-23 23:37:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Provide pathmunge for profile.d scripts (871 bytes, patch)
2010-03-15 17:55 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2009-12-19 17:45:17 UTC
zsh should provide the "pathmunge" function for the duration it loads profile.d scripts for non-login shells from /etc/zshrc.  See bug 123621 for more info.

Comment 1 Ville Skyttä 2010-02-21 19:14:42 UTC
Any news about this?  I'd like to know if I need to work around this in my packages for F-13.

Comment 2 James Antill 2010-03-08 20:27:18 UTC
zsh is pretty much the last thing on my TODO list ... if you provide a patch, chances are I'll fix this omission (or, even better, apply for co-maintainer status :)

Comment 3 Bug Zapper 2010-03-15 13:38:03 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Ville Skyttä 2010-03-15 17:55:05 UTC
Created attachment 400276 [details]
Provide pathmunge for profile.d scripts

Here's a patch that appears to work, basically just copy/pasted the function from /etc/profile.  I don't use zsh myself so my co-maintainership would not make much sense... and someone familiar with zsh scripting should review the patch.

Comment 5 Jim Meyering 2010-03-19 21:00:16 UTC
As I mentioned in #571549, that patch works for me.  Thanks.

Comment 6 Ville Skyttä 2010-03-20 09:49:49 UTC
James, let me know if you'd like me to apply this and do the builds.

Comment 7 James Antill 2010-03-22 14:11:44 UTC
I've just built this in devel and F-13

http://koji.fedoraproject.org/koji/taskinfo?taskID=2067803

http://koji.fedoraproject.org/koji/taskinfo?taskID=2067815

...I'll push directly to F-13/stable.

Comment 8 Fedora Update System 2010-03-22 14:22:27 UTC
zsh-4.3.10-5.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/zsh-4.3.10-5.fc13

Comment 9 Fedora Update System 2010-03-23 23:37:13 UTC
zsh-4.3.10-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Ville Skyttä 2010-03-24 09:41:57 UTC
*** Bug 571549 has been marked as a duplicate of this bug. ***

Comment 11 Aviad Reich 2010-06-04 04:28:12 UTC
(In reply to comment #9)
> zsh-4.3.10-5.fc13 has been pushed to the Fedora 13 stable repository.  If
> problems still persist, please make note of it in this bug report.    

after updating to f13, i get this message when starting zsh:
"/etc/profile.d/ccache.sh:4: command not found: pathmunge"

yum info zsh:

Installed Packages
Name       : zsh
Arch       : x86_64
Version    : 4.3.10
Release    : 5.fc13

Comment 12 Aviad Reich 2010-06-04 04:33:19 UTC
(In reply to comment #9)
> zsh-4.3.10-5.fc13 has been pushed to the Fedora 13 stable repository.  If
> problems still persist, please make note of it in this bug report.    

after updating to f13, i get this message when starting zsh:
"/etc/profile.d/ccache.sh:4: command not found: pathmunge"

yum info zsh:

Installed Packages
Name       : zsh
Arch       : x86_64
Version    : 4.3.10
Release    : 5.fc13

Comment 13 James Antill 2010-06-04 14:23:57 UTC
Aviad, /etc/zshrc is a config. file ... have you altered it? Is there a /etc/zshrc.rpmnew ?
 What does your /etc/zshrc look like?

Comment 14 Aviad Reich 2010-06-04 17:53:00 UTC
(In reply to comment #13)
> Aviad, /etc/zshrc is a config. file ... have you altered it? Is there a
> /etc/zshrc.rpmnew ?
>  What does your /etc/zshrc look like?    

First of all, "cp /etc/zshrc.rpmnew /etc/zshrc" solved it - thanks!

(I did make some changes to /etc/zshrc, probably causing the patch not to be automatically included.)

Comment 15 Fedora Update System 2010-06-04 20:14:07 UTC
ccache-2.4-18.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ccache-2.4-18.fc13

Comment 16 Ville Skyttä 2010-06-04 20:15:31 UTC
(In reply to comment #13)
> Aviad, /etc/zshrc is a config. file ... have you altered it? Is there a
> /etc/zshrc.rpmnew ?

I managed to miss this scenario, sorry.  ccache-2.4-18.fc13 gets rid of use of pathmunge.

Comment 17 Fedora Update System 2010-06-23 17:51:56 UTC
ccache-2.4-18.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.