Red Hat Bugzilla – Bug 554717
RFE: Better groups exclusion support
Last modified: 2010-07-01 16:57:54 EDT
Description of problem:
pykickstart does not support exclusion of groups that were not previously added in the %packages section.
Red Hat QE needs this so that we can execute test cases such as:
Version-Release number of selected component (if applicable):
Package exclusion works the same way we'd like groups exclusion to work. For example:
Patch proposed by by James Laska and tested:
--- /usr/lib/python2.5/site-packages/pykickstart/parser.py 2010-01-07
+++ /tmp/parser.py 2010-01-07 04:16:29.000000000 -0500
@@ -365,4 +365,3 @@
Has this actually been tested in an install? I don't see how just adding the excluded group to newExcludedSet is going to help. That'll mean the group name gets into self.excludedList, which then gets passed on to YumBackend.deselectPackage. I don't think that's doing anything magic to iterate over the packages in a group, or knows to deselect the group as opposed to a package.
It almost seems like we need an extra list here of groups to exclude, then call the appropriate thing in anaconda. Of course, I could just not be following the patch correctly.
(In reply to comment #1)
> Has this actually been tested in an install?
No. What I meant is that we've tested that pykickstart with this patch will generate a proper ks.cfg file.
I've started a test job with manually created ks.cfg file to see how anaconda will interpret it. It's likely that anaconda will require another fix or modification of this patch.
Can you attach a test script and example of what a "proper ks.cfg file" looks like? I want to test an alternate patch here and make sure we get the same results.
A test script is the following SNAKE template:
from pykickstart.version import FC6
from installdefaults import InstallKs
# minimal install, procedural style
'''Package set / Everything'''
if ks.version <= FC6:
The result should contain (along with other default values):
Okay, fixing this to work in anaconda too makes things a whole lot more complicated, but I think I've managed to make sense of it all. This should now work like you want both in pykickstart's __str__ methods and in anaconda.
can you post your patch or an updates.img for RHEL5.5 so I can give it a try?
This works OK for QE. snake.test server now generates a ks.cfg with