Created attachment 384876 [details] Patch which fixes the described issues. Description of problem: Calling vt.get_text and passing True for do_attrs causes a segfault, because the cht variable in build_attributes is never initialized. Attached is a patch which fixes the bug, and also these other bugs & warnings: 1. Refcounting in call_callback is incorrect; do not decref the callback function until after it's called. 2. Eliminate signed/unsigned warning in build_attributes; use guint instead of int. 3. Remove unused count variables from get_text and related functions. These were leftover from when the attribute code was duplicated in each. 4. match_check returns a string and an int, but the local variable was declared as int*. Change int* tag to int tag. 5. get_text and related methods are written to support callback=NULL, however the call to PyArg_ParseTupleAndKeywords makes it a required parameter. Changed instances of O|OO to |OOO. Version-Release number of selected component (if applicable): This was all tested on F12, but the code appears to be the same in devel. How reproducible: 100%
This message is a reminder that Fedora 12 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 12. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '12'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 12's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 12 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
Wow. This is an old one. ;) Does this still apply to vte in rawhide? Was it ever merged upstream?
Looks like the affected (buggy) code is unchanged in vte-0.28.2.tar.bz2, so yes it looks to still be broken. When I reported this bug, I worked around it in the application I was working on (Terminal activity for Sugar). I can't find any Python bindings at all in the newer vte3 Fedora project.
Have you submitted this upstream? Or would you like me to do so?
If you're willing to submit it upstream, that would be wonderful.
Sorry for the massive delay here. Slipped down on my list. Upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=671283
So, 0.28.x is no longer maintained upstream and they dropped the python bindings in 0.29.x. ;( Sorry.
Hum, looking at things further... 0.28.x is the last release that supported gtk2, so we are going to be stuck with it a while. So, I might update to 0.28.2 and just ship your patches. Re-opening for that.
Built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3878034