Bug 556625 - Review Request: milia - C++ cosmology library
Summary: Review Request: milia - C++ cosmology library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 556628
TreeView+ depends on / blocked
 
Reported: 2010-01-18 21:55 UTC by Sergio Pascual
Modified: 2010-01-24 22:03 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-01-24 22:03:50 UTC
Type: ---
Embargoed:
tomspur: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Sergio Pascual 2010-01-18 21:55:51 UTC
Spec URL: http://guaix.fis.ucm.es/~spr/milia.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/milia-0.3.0-1.fc12.src.rpm
Description: Milia is a C++ library created to compute cosmological 
distances and ages in the Friedmann-Lemaître-Robertson-Walker metric. The luminosity distance is computed using elliptical functions 
(Kantowski, Kao, Thomas 2000). 
The remaining distances are computed from the luminosity distance using 
Hogg 1999. The age is computed following Thomas & Kantowski 2000, using also 
elliptical functions.

Comment 1 Thomas Spura 2010-01-19 10:07:33 UTC
Your server seems to be down :(

Comment 2 Sergio Pascual 2010-01-19 11:13:11 UTC
Upss, it's fixed now

Comment 3 Sergio Pascual 2010-01-19 17:10:55 UTC
I have upload the files to fedorapeople also


Spec URL: http://sergiopr.fedorapeople.org/milia.spec
SRPM URL: http://sergiopr.fedorapeople.org/milia-0.3.0-1.fc12.src.rpm

Comment 4 Thomas Spura 2010-01-20 03:44:03 UTC
Review:

Good:
- name ok
- group ok
- builds cleanly
- %check is there
- %clean is there
- no static libs
- *.so.* in package
- *.so in devel
- license ok
- %doc ok
- no *.la
- rpmlint ok:
$ rpmlint milia-0.3.0-1.fc12.src.rpm x86_64/*
milia-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.



Cosmetic issues (Should):
- Could you delete all *.la files in %install?
  Like: find -name '*.la' | xargs rm -f
  %exclude .../*.la is ok, too.



Blocker:
- BR: pkgconfig is not needed anymore (except you want to build in EPEL)
  But then, but this BR into the *subpackage*.
  If you build for fedora, delete it.
- permissions: you missed the last ',-' in %defattr(-,root,root,-) of -devel
- sources do not match upstream:
  your sources: f54fde2157cc213aebf676ac84e3684e
  upstream:     ff0d1a97d14548bc1ac215638f6d1cf8
  What have you done? ;)

Comment 5 Sergio Pascual 2010-01-20 08:43:35 UTC
Spec URL: http://sergiopr.fedorapeople.org/milia.spec
SRPM URL: http://sergiopr.fedorapeople.org/milia-0.3.0-1.fc12.src.rpm

I have removed the requires pkgconfig, I'll put it again in the epel branch. The tarballs are identical except for the timestamp :). It should be fixed now.

I have left the %exclude .../*.la, it seems more clear to me.

Comment 6 Sergio Pascual 2010-01-20 08:46:18 UTC
Sorry, these are the correct links

Spec URL: http://sergiopr.fedorapeople.org/milia.spec
SRPM URL: http://sergiopr.fedorapeople.org/milia-0.3.0-2.fc12.src.rpm

Comment 7 Thomas Spura 2010-01-20 11:57:50 UTC
Sources are now both: ff0d1a97d14548bc1ac215638f6d1cf8

Any other blocker are done.


######################################

APPROVED

Comment 8 Sergio Pascual 2010-01-20 12:09:10 UTC
New Package CVS Request
=======================
Package Name: milia
Short Description: C++ cosmology library
Owners: sergiopr
Branches: F-12 F-11 EL-5
InitialCC:

Comment 9 Jason Tibbitts 2010-01-24 17:33:48 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.