Bug 557010 - RFE: pptp support
Summary: RFE: pptp support
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: initscripts
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Lukáš Nykrýn
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-20 05:16 UTC by Cepreu
Modified: 2016-04-21 10:36 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-21 10:36:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Ifdown script (636 bytes, application/octet-stream)
2010-01-20 05:17 UTC, Cepreu
no flags Details
Ifup script (2.59 KB, application/octet-stream)
2010-01-20 05:17 UTC, Cepreu
no flags Details
Documentation (40.47 KB, text/plain)
2010-01-20 12:39 UTC, Cepreu
no flags Details
ifup script (5.81 KB, application/octet-stream)
2010-03-10 00:39 UTC, Cepreu
no flags Details
ifdown script (1.12 KB, application/octet-stream)
2010-03-10 00:39 UTC, Cepreu
no flags Details

Description Cepreu 2010-01-20 05:16:58 UTC
Description of problem:
I created some patch for system-config-network with PPTP-connection support. But this connections must have ifup and ifdown files for working. So i attach this files with this feature request.
Link to appropriate system-config-network request: https://bugzilla.redhat.com/show_bug.cgi?id=550054.
See an attachement with ifup-pptp and ifdown-pptp scripts. But this files need some support in /ets/sysconfig/network-scripts/network-functions file.
I can't find a cvs or svn of initscripts to create patch file for it.
So i send you scripts and ask to modify network-functions: just two lines in source_config () function with new connection type:
    case "$TYPE" in
    ....
	PPTP | pptp)
		DEVICETYPE="pptp"
		;;
Thanks in advance. Cepreu.

Comment 1 Cepreu 2010-01-20 05:17:30 UTC
Created attachment 385585 [details]
Ifdown script

Comment 2 Cepreu 2010-01-20 05:17:56 UTC
Created attachment 385586 [details]
Ifup script

Comment 3 iarly selbir 2010-01-20 11:37:32 UTC
Thanks for your report.

--
Fedora Bugzappers Team Member

Comment 4 Cepreu 2010-01-20 12:39:03 UTC
Sorry, i temporarily forget about sending documentation for this scripts. See an attachment with sysconfig.txt file, where new type of config documented at the end of file.

Comment 5 Cepreu 2010-01-20 12:39:34 UTC
Created attachment 385668 [details]
Documentation

Comment 6 Bill Nottingham 2010-01-20 16:12:29 UTC
1) This shares so much code with the ppp code, it would seem to make more sense to leverage that somehow

2) Ideally, new connection type support is supported via NM, not via the legacy network scripts.

Comment 7 Cepreu 2010-01-21 01:37:15 UTC
1) There is two ways to solve it. First: use standard ifup-ppp with empty MODEMPORT, LINESPEED, 60% settings, which needed to pptp connections, stored in PPPOPTIONS string. Negative side - not beautiful config and hard to reading settings in GUI part. Second: transfer shared code from ifup files to network-functions. Negative side - need serious modifications of ifup-ppp and network-functons. So i can do nothing or realize first method, or second, if you say.

2) This connection type are supported in NM, but there is some problem in concept of NM, which make this support useless in some situations: there is no way to establish connection from command line and without login in system, there is no way to forbid controlling of connection for non-root users. All of it because NM created for desktops. But enumerated things can be very useful for small offices or servers.

Comment 8 Cepreu 2010-03-10 00:37:40 UTC
Hi again. There is modified ifup-ppp, and ifdown-ppp scripts. So now support of pptp connections in this scripts. It helps to reduce amount of shared code. ifup-pptp and ifdown-pptp now must be just symbolic links to ifup-ppp and ifdown-pptp.

Comment 9 Cepreu 2010-03-10 00:39:13 UTC
Created attachment 398973 [details]
ifup script

Comment 10 Cepreu 2010-03-10 00:39:43 UTC
Created attachment 398974 [details]
ifdown script

Comment 11 Cepreu 2010-03-10 00:41:07 UTC
(In reply to comment #8)
> Hi again. There is modified ifup-ppp, and ifdown-ppp scripts. So now support of
> pptp connections in this scripts. It helps to reduce amount of shared code.
> ifup-pptp and ifdown-pptp now must be just symbolic links to ifup-ppp and
> ifdown-pptp.    

Fix: ...symbolic links to ifup-ppp and ifdown-ppp.

Comment 12 Cepreu 2010-03-13 04:55:24 UTC
I am sorry, but may i help you somehow to integrate this pathes in upstream? Maybe initsripts have some git, cvs or something similar and i can create patch for this repository latest version? Or i can download latest fedora (beta 13, for example) and modify their ifup-ppp, ifdown-ppp and send you? Because files, which i send you - it is my modifications to fedora 11 scripts (i use it myself).
Please, give me your advice, how i can be useful in this matter?

Comment 13 Bill Nottingham 2010-03-16 14:59:09 UTC
I am currently busy with other tasks; I hope to get to looking at this in the next couple of weeks. Please be patient.

Comment 14 Cepreu 2010-03-16 22:01:16 UTC
Ok, thanks for attention.

Comment 15 Fedora Admin XMLRPC Client 2013-09-04 14:50:53 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 16 Lubomir Rintel 2016-04-21 10:23:28 UTC
(In reply to Cepreu from comment #7)
> 2) This connection type are supported in NM, but there is some problem in
> concept of NM, which make this support useless in some situations: there is
> no way to establish connection from command line

There is a way now, with nmcli.

> and without login in
> system,

Of course there is; the connections can be set to autoconnect.

> there is no way to forbid controlling of connection for non-root
> users.

There is. Non-root users can't control networking (unless they are active console users). You can configure this with Policykit.

> All of it because NM created for desktops. But enumerated things can
> be very useful for small offices or servers.

We support server setups too.

I guess this is now obsolete and can be closed?


Note You need to log in before you can comment on or make changes to this bug.