Spec URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n-1.3.0-1.fc12.src.rpm Description: Internationalization and localization utilities
Updated version with extra BuildRequirement: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n-1.3.0-2.fc12.src.rpm
I reviewed this package. There are a few minor things but none of them are blockers. Please read through and modify the specfile if there is need before you commit ! rpmlint says: aduna-commons-i18n.src:123: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} This can be ignored. By the way you can get rid of the "%attr(-,root,root)" part aduna-commons-i18n.x86_64: W: no-documentation This can be ignored aduna-commons-i18n.x86_64: W: non-conffile-in-etc /etc/maven/fragments/aduna-commons-i18n This can be ignored ! %description for javadoc subpackage should not be the same description for the main package. ? This looks like a SUSE convention %{_javadocdir}/%{name}-%{version} %{_javadocdir}/%{name} Do we have this in Fedora? If not, please remove the symlink. ! It looks like the following BR's are not really needed: BuildRequires: maven2 BuildRequires: maven2-plugin-compiler BuildRequires: maven2-plugin-javadoc BuildRequires: maven-plugin-bundle These will be pulled in by other dependencies so it won't do harm to leave them but the following , I think, is absolutely not needed. BuildRequires: maven-surefire-provider-junit ----------------------------------------------------- This package (aduna-commons-i18n) is APPROVED by oget -----------------------------------------------------
New version: - Remove BuildRequirements that are pulled in by aduna-commons POM - Require the main package in the javadoc http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n.spec http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-i18n-1.3.0-3.fc12.src.rpm
Mary Ellen, in case you didn't notice, I already approved the package in comment #2.
New Package CVS Request ======================= Package Name: aduna-commons-i18n Short Description: Internationalization and localization utilities Owners: mef Branches: F-12 InitialCC:
(Sorry for the duplicate -- I got a bugzilla server error the first time ...)
CVS done (by process-cvs-requests.py). (added a F-13 branch as well)
The package doesn't seem to be imported to cvs yet. Is there a problem?
Mary, is there something wrong?
I retired and blocked the package.