Spec URL: http://mifo.sk/rubygem-rest_client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-1.fc12.src.rpm Description: A simple Simple HTTP and REST client for Ruby, inspired by the Sinatra microframework style of specifying actions: get, put, post, delete.
1.) Your spec file is incorrectly named, please s/_/-/ 2.) You lack the ruby abi dependency. Please add Requires: ruby(abi) = 1.8 In other respects the package seems fine: * Correctly named * Correctly versioned, packing the latest version * Source checksum correct * SPEC file clean and legible * American english used * Documentation files marked correctly * License correct and permitted in Fedora * Builds fine in mock
Thank you Lubomir, 1) Fixed 2) Added Spec URL: http://mifo.sk/rubygem-rest-client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-1.fc12.src.rpm
This package looks sane and is approved. Setting fedora-review FLAGA. APPROVED
New Package CVS Request ======================= Package Name: rubygem-rest-client Short Description: Simple REST client for Ruby Owners: mfojtik Branches: F-11 F-12 EL-5
Quick notes: - README.rdoc says that license is under MIT - build.log says there is some duplicate %files entry, please fix this (this is a MUST item) https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles - Now we prefer to use %global over %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - Please use %geminstdir macro in %files list because you have explicitly defined this.
(In reply to comment #5) > Quick notes: > > - README.rdoc says that license is under MIT FIXED > - build.log says there is some duplicate %files entry, > please fix this (this is a MUST item) > https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles FIXED > - Now we prefer to use %global over %define FIXED > > https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define > - Please use %geminstdir macro in %files list because you have > explicitly defined this. FIXED Thanks for all suggestions Mamoru! Spec URL: http://mifo.sk/rubygem-rest-client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-1.fc12.src.rpm
(In reply to comment #6) > (In reply to comment #5) > > - build.log says there is some duplicate %files entry, > > please fix this (this is a MUST item) > > https://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > FIXED - Well, please mark "README.rdoc" or so as %doc properly. Also please change the release number of your spec file every time you modify your srpm (even during package review) to avoid confusion.
Sure, I marked 'README.rdoc' and 'spec/' and 'history.md' as %doc as well. Release number is 4 (4 modification of spec file): Spec URL: http://mifo.sk/rubygem-rest-client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-4.fc12.src.rpm
Well, - %{geminstdir}/.yardoc seem to be installed but is not listed in %files. Please add this (and perhaps this can be added as %doc) - Also add "%dir %{geminstdir}" to %files And this seems okay. Note: Now F-13 is branched.
(In reply to comment #9) > Well, > - %{geminstdir}/.yardoc seem to be installed but is not > listed in %files. Please add this (and perhaps this can > be added as %doc) I can't see any file with this name. Also when I add this line into %files, rpmbuild fails. Any details ? > - Also add "%dir %{geminstdir}" to %files FIXED Spec URL: http://mifo.sk/rubygem-rest-client.spec SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-5.fc12.src.rpm
(In reply to comment #10) > (In reply to comment #9) > > Well, > > - %{geminstdir}/.yardoc seem to be installed but is not > > listed in %files. Please add this (and perhaps this can > > be added as %doc) > > I can't see any file with this name. Also when I add this line into %files, > rpmbuild fails. Any details ? - Ah, I have rubygem-yard (bug 562993) installed and this overrides "$ gem install" behavior. > > - Also add "%dir %{geminstdir}" to %files > > FIXED > > Spec URL: http://mifo.sk/rubygem-rest-client.spec > SRPM URL: http://mifo.sk/rubygem-rest-client-1.3.1-5.fc12.src.rpm Looks good.
New Package CVS Request ======================= Package Name: rubygem-rest-client Short Description: Simple REST client for Ruby Owners: mfojtik Branches: F-11 F-12 F-13 EL-5
CVS done (by process-cvs-requests.py).
rubygem-rest-client-1.3.1-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-rest-client-1.3.1-5.fc11
rubygem-rest-client-1.3.1-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-rest-client-1.3.1-5.fc12
rubygem-rest-client-1.3.1-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-rest-client-1.3.1-5.fc13
rubygem-rest-client-1.3.1-5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-rest-client-1.3.1-5.el5
rubygem-rest-client-1.3.1-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rest-client-1.3.1-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rest-client-1.3.1-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rest-client-1.3.1-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: rubygem-rest-client New Branches: EL-6 Owners: mfojtik
rubygem-rest-client-1.6.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-rest-client-1.6.1-1.fc13
rubygem-rest-client-1.6.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-rest-client-1.6.1-1.fc14
rubygem-rest-client-1.6.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-rest-client-1.6.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: rubygem-rest-client New Branches: epel7 Owners: tdawson
Git done (by process-git-requests).