SPEC: http://pbrobinson.fedorapeople.org/mutter-mbl.spec SRPM: http://pbrobinson.fedorapeople.org/mutter-mbl-2.28.1_0.12-1.fc12.src.rpm Description: Mutter-mbl is a fork of the mutter window and compositing manager that displays and manages your desktop via OpenGL. Mutter combines a sophisticated display engine using the Clutter toolkit with solid window-management logic inherited from the Metacity window manager.
I'll review this one over the weekend!
Thanks! koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2076085
LANG=C rpm -Uvh /home/che/rpmbuild/RPMS/x86_64/mutter-mbl-2.28.1_0.12-1.fc14.x86_64.rpm /home/che/rpmbuild/RPMS/x86_64/mutter-mbl-devel-2.28.1_0.12-1.fc14.x86_64.rpm error: Failed dependencies: mutter conflicts with mutter-mbl-2.28.1_0.12-1.fc14.x86_64 mutter-devel conflicts with mutter-mbl-devel-2.28.1_0.12-1.fc14.x86_64 please get the conflicts resolved. if it is a real fork then there is no reason to keep the old names or just prefix or suffix them with mbl or whatever. please not yet another conflicting package.
> please get the conflicts resolved. if it is a real fork then there is no reason > to keep the old names or just prefix or suffix them with mbl or whatever. > please not yet another conflicting package. Its a know issue and is planned to be short term while the two upstreams get things sorted. I plan to get a patch into it to change the prefixes but it is not done yet. It is explicitly for Meego while upstream disagree between particular issues. Without it Moblin/Meego will be removed from Fedora.
Alright, here comes the review stuff. It looks like upstream is currently still moving stuff around between Moblin and Meego, so I can currently check neither version numbering nor the latest version. A couple of comments: * please you either %{buildroot} or $RPM_BUILD_ROOT * there's apparently some noise in rpmlint - the spelling errors can obviously be ignored but the other stuff might need an eye. As soon as upstream gets the repo up again, we should be able to proceed here. [ OK ] specfiles match: 46952998dd5bcd4925e693285a6464da [ -- ] source files match upstream: N/A [ -- ] package meets naming and versioning guidelines. [ -- ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ -- ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=2076085 [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ -- ] rpmlint is silent: [sebastian@localhost ~]$ rpmlint mutter-mbl-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl.i686: W: spelling-error Summary(en_US) compositing -> composting, com positing, com-positing mutter-mbl.i686: W: spelling-error %description -l en_US compositing -> composting, com positing, com-positing mutter-mbl.i686: W: incoherent-version-in-changelog 2.28.1_0.10-1 ['2.28.1_0.12-1.fc14', '2.28.1_0.12-1'] mutter-mbl.i686: W: shared-lib-calls-exit /usr/lib/libmutter-private.so.0.0.0 exit mutter-mbl.i686: W: non-conffile-in-etc /etc/gconf/schemas/mutter.schemas 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [sebastian@localhost ~]$ rpmlint mutter-mbl-devel-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl-devel.i686: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [sebastian@localhost ~]$ rpmlint mutter-mbl-debuginfo-2.28.1_0.12-1.fc14.i686.rpm mutter-mbl-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/mutter-2.28.1_0.12/src/compositor/mutter-shaped-texture.c 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [ OK ] final provides and requires are sane [ NA ] %check is present and all tests pass [ OK ] no shared libraries are added to the regular linker search paths. [ NA ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] docs subpackage is appropriately created [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] headers go into devel package. [ OK ] pkgconfig files are in devel package. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly.
Updated to the current available upstream source with spec file fixed. http://pbrobinson.fedorapeople.org/mutter-mbl-2.28.1_0.0-1.fc12.src.rpm
Okay, thanks for adding the source URL and instructions. This looks good now, APPROVED.
Thanks! New Package CVS Request ======================= Package Name: mutter-mbl Short Description: Window and compositing manager based on Clutter Owners: pbrobinson Branches: F-13 InitialCC:
CVS done (by process-cvs-requests.py).
*** Bug 544640 has been marked as a duplicate of this bug. ***
Build in rawhide and F-13