Spec URL: http://oget.fedorapeople.org/review/libqxt.spec SRPM URL: http://oget.fedorapeople.org/review/libqxt-0.6.0-0.1.20100327hg.fc12.src.rpm Description: LibQxt, an extension library for Qt, provides a suite of cross-platform utility classes to add functionality not readily available in the Qt toolkit. The developers advised me to package the trunk version, which is codewise ready. It will be released as stable in a couple days, with minor modifications to the documentation only.
Spec URL: http://oget.fedorapeople.org/review/libqxt.spec SRPM URL: http://oget.fedorapeople.org/review/libqxt-0.6.0-0.2.20100407hg.fc12.src.rpm Changelog: - New snapshot. The previous tarball got damaged somehow. - Remove configure tests hack. Upstream fixed it upon our warning. I think there was a problem with fedorapeople.org. Anyway, I uploaded a new SRPM. Thanks to chkr for pointing this out.
I can take a look today.
First question, why a snapshot, and not 0.5.1 release? And, if you're going to use snapshots, I'd suggest naming the tarball differently, to something like libqxt-20100407hg.tar.bz2 for example. Doing otherwise is an easy source of error. Of course, using snapshots here will likely be short-lived, right?.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2102499 rpmlint: $ rpmlint *.rpm libqxt.src:50: W: configure-without-libdir-spec libqxt.src: W: invalid-url Source0: libqxt.tar.bz2 libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/gui/release/.rcc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/gui/release/.rcc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/core/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/core/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/designer/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/designer/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/sql/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/sql/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/gui/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/gui/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/web/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/web/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/zeroconf/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/zeroconf/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/designer/release/.rcc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/designer/release/.rcc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/network/release/.moc libqxt-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/libqxt/src/network/release/.moc 4 packages and 0 specfiles checked; 0 errors, 20 warnings.
Naming: ok License: ok macros: ok but, you do have these for use: %_qt4_plugindir (instead of %_qt4_prefix/plugins) %_qt4_qmake (intead of %{_bindir}/qmake-qt4 %_qt4_datadir/mkspecs (instead of %_qt4_prefix/mkspecs) scriptlets: ok %files: ok (but it may be worth tracking lib sonames closer , to make abi breaks more obvious) SHOULD: I'd recommend adding a %{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}} in the main package for paranoia. you can probably drop the %{?_qt4_version conditional, if this is going to be a fedora-only package. Pending the question about using a snapshot vs. 0.5.1, I don't see any review blockers.
(In reply to comment #5) Thanks Rex, > macros: ok > but, you do have these for use: > %_qt4_plugindir (instead of %_qt4_prefix/plugins) > %_qt4_qmake (intead of %{_bindir}/qmake-qt4 > %_qt4_datadir/mkspecs (instead of %_qt4_prefix/mkspecs) > sure, I'll replace those. > %files: ok (but it may be worth tracking lib sonames closer , to make abi > breaks more obvious) > I'll keep an eye. > SHOULD: I'd recommend adding a > %{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}} > in the main package for paranoia. you can probably drop the %{?_qt4_version > conditional, if this is going to be a fedora-only package. > :) ok. > > Pending the question about using a snapshot vs. 0.5.1, I don't see any review > blockers. Please see the original post for the answer. According to the developers, most of them are done with their work. There is one developer who needs to finish writing the documentation for certain classes. The new version will be released soon, at least that's what they say. After that, I will only go with stable release versions, unless there is a strong reason to do otherwise.
ok, I'm satisfied. APPROVED.
Thanks! New Package CVS Request ======================= Package Name: libqxt Short Description: Qt extension library Owners: oget Branches: F-11 F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
libqxt-0.6.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc13
libqxt-0.6.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc12
libqxt-0.6.0-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc11
libqxt-0.6.0-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libqxt'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc13
libqxt-0.6.0-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libqxt'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc12
libqxt-0.6.0-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libqxt'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libqxt-0.6.0-2.fc11
libqxt-0.6.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
libqxt-0.6.0-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
libqxt-0.6.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: qtsingleapplication New Branches: el6 epel7 Owners: fale
Package Change Request ====================== Package Name: libqxt New Branches: el6 epel7 Owners: fale
Sorry for the comment #19, copy&paste error :(
Git done (by process-git-requests).