SPEC: http://pbrobinson.fedorapeople.org/pyclutter-gst.spec SRPM: http://pbrobinson.fedorapeople.org/pyclutter-gst-1.0.0-1.fc12.src.rpm Description: This archive contains the Python modules that allow you to use the Clutter toolkit in Python programs. This package provides the binding for clutter-gtk koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2093727
review: + Package meets naming and packaging guidelines + Spec file matches base package name. ? Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Package@localhost SPECS]$ md5sum pyclutter-gst-1.0.0.tar.bz2 b1cc99a70042bb91ad75937405ed64d9 pyclutter-gst-1.0.0.tar.bz2 [Package@localhost SPECS]$ md5sum ../SOURCES/pyclutter-gst-1.0.0.tar.bz2 b1cc99a70042bb91ad75937405ed64d9 ../SOURCES/pyclutter-gst-1.0.0.tar.bz2 - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun + .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. + -devel package Requires: %{name} = %{version}-%{release} + .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. + Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1.change %{buildroot} to $RPM_BUILD_ROOT on line 52 The rest looks okay.
> 1.change %{buildroot} to $RPM_BUILD_ROOT on line 52 Already have updated on my local copy. > The rest looks okay. Any reason you haven't approved it then, the minor fix is done locally and doesn't overly impact the approval of the package.
Well, Generally you're supposed to upload the new *final* srpm for the reviewer to check ;) Ankur
XXX APPROVED XXX
Thanks! New Package CVS Request ======================= Package Name: pyclutter-gst Short Description: Python modules that allow you to use the Clutter-GST toolkit Owners: pbrobinson Branches: F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Closed and built in rawhide/F-13. Update submitted for F-13. Thanks for the review.