Bug 579288 - Review Request: pyclutter-gst - Python modules that allow you to use the Clutter-GST toolkit
Summary: Review Request: pyclutter-gst - Python modules that allow you to use the Clut...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Ankur Sinha (FranciscoD)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-03 22:57 UTC by Peter Robinson
Modified: 2010-04-14 22:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-04-14 22:28:45 UTC
sanjay.ankur: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peter Robinson 2010-04-03 22:57:41 UTC
SPEC: http://pbrobinson.fedorapeople.org/pyclutter-gst.spec
SRPM: http://pbrobinson.fedorapeople.org/pyclutter-gst-1.0.0-1.fc12.src.rpm

Description:
This archive contains the Python modules that allow you to use the
Clutter toolkit in Python programs.

This package provides the binding for clutter-gtk

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2093727

Comment 1 Ankur Sinha (FranciscoD) 2010-04-14 10:57:44 UTC
review:

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
? Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[Package@localhost SPECS]$ md5sum pyclutter-gst-1.0.0.tar.bz2 
b1cc99a70042bb91ad75937405ed64d9  pyclutter-gst-1.0.0.tar.bz2
[Package@localhost SPECS]$ md5sum ../SOURCES/pyclutter-gst-1.0.0.tar.bz2 
b1cc99a70042bb91ad75937405ed64d9  ../SOURCES/pyclutter-gst-1.0.0.tar.bz2

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

+ Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
+ .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
+ -devel package Requires: %{name} = %{version}-%{release}
+ .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and anything provided by glibc.)

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
+ Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1.change %{buildroot} to $RPM_BUILD_ROOT on line 52

The rest looks okay.

Comment 2 Peter Robinson 2010-04-14 11:03:02 UTC
> 1.change %{buildroot} to $RPM_BUILD_ROOT on line 52

Already have updated on my local copy.
 
> The rest looks okay.    

Any reason you haven't approved it then, the minor fix is done locally and doesn't overly impact the approval of the package.

Comment 3 Ankur Sinha (FranciscoD) 2010-04-14 11:16:29 UTC
Well,
Generally you're supposed to upload the new *final* srpm for the reviewer to check ;)

Ankur

Comment 4 Ankur Sinha (FranciscoD) 2010-04-14 11:44:07 UTC
XXX APPROVED XXX

Comment 5 Peter Robinson 2010-04-14 11:52:21 UTC
Thanks!

New Package CVS Request
=======================
Package Name: pyclutter-gst
Short Description: Python modules that allow you to use the Clutter-GST toolkit
Owners: pbrobinson
Branches: F-13
InitialCC:

Comment 6 Kevin Fenzi 2010-04-14 21:52:51 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Peter Robinson 2010-04-14 22:28:45 UTC
Closed and built in rawhide/F-13. Update submitted for F-13. Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.