SPEC: http://pbrobinson.fedorapeople.org/pyclutter-gtk.spec SRPM: http://pbrobinson.fedorapeople.org/pyclutter-gtk-0.10.0-1.fc12.src.rpm Description: This archive contains the Python modules that allow you to use the Clutter toolkit in Python programs. This package provides the binding for clutter-gtk koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2093737
review: + Package meets naming and packaging guidelines + Spec file matches base package name. ? Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Package@localhost SPECS]$ md5sum pyclutter-gtk-0.10.0.tar.bz2 01ab4dc60e7d00737e372f38fdefa9f2 pyclutter-gtk-0.10.0.tar.bz2 [Package@localhost SPECS]$ md5sum ../SOURCES/pyclutter-gtk-0.10.0.tar.bz2 01ab4dc60e7d00737e372f38fdefa9f2 ../SOURCES/pyclutter-gtk-0.10.0.tar.bz2 - Package needs ExcludeArch - BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun ? .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. + -devel package Requires: %{name} = %{version}-%{release} + .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. [Package@localhost SPECS]$ rpmlint pyclutter-gtk.spec ../SRPMS/pyclutter-gtk-0.10.0-1.fc12.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. [Package@localhost SRPMS]$ rpmlint pyclutter-gtk-0.10.0-1.fc12.src.rpm ../RPMS/x86_64/pyclutter-gtk-* pyclutter-gtk-devel.x86_64: W: no-documentation - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: + Should build in mock. + Should build on all supported archs ? Should function as described. - Should have sane scriptlets. + Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1.change %{buildroot} to $RPM_BUILD_ROOT on line 51 2.If the package is intended for EPEL 5 also,I think you need to Requires: pkgconfig https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files 3. not checked functioning. failed to build rpm for f12 4. rpmlint gives error since devel has no docs here. Isn't something major here.
> 1.change %{buildroot} to $RPM_BUILD_ROOT on line 51 I'll update it to use all %{buildroot} as that's the newer preferred option. Sorry cut'n'paste error. > 2.If the package is intended for EPEL 5 also,I think you need to Requires: > pkgconfig > https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files Nope, it needs clutter 1.2 which isn't in EL at all. It will only be F-13 and later. > 3. not checked functioning. failed to build rpm for f12 Needs clutter 1.2 so it will fail. > 4. rpmlint gives error since devel has no docs here. Isn't something major > here. Nope, its not.
> > Nope, it needs clutter 1.2 which isn't in EL at all. It will only be F-13 and > later. okay, the first line checks for EL version too. That's what made me think it's going to be up for EL. Ankur
(In reply to comment #3) > > > > Nope, it needs clutter 1.2 which isn't in EL at all. It will only be F-13 and > > later. > > okay, the first line checks for EL version too. That's what made me think it's > going to be up for EL. Came from a generic template I have.
XXX APPROVED XXX
Thanks! New Package CVS Request ======================= Package Name: pyclutter-gtk Short Description: Python modules that allow you to use the Clutter-GTK toolkit Owners: pbrobinson Branches: F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Closed and built in rawhide/F-13. Update submitted for F-13. Thanks for the review.