Spec URL: http://peter.fedorapeople.org/erlang-oauth.spec SRPM URL: http://peter.fedorapeople.org/erlang-oauth-0-0.1.gite8aecf0.fc12.src.rpm Description: An Erlang OAuth implementation. This library is bundled with CouchDB.
Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=2182797 rpmlint: Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-oauth-0-0.1.gite8aecf0.fc12.ppc.rpm erlang-oauth.ppc: E: no-binary erlang-oauth.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Sulaco ~/rpmbuild/SPECS: Both messages *must* be ignored - in fact, application contains only noarch-data, but installed into arch-specific %{_libdir}. Unlike python stuff being divided into noarch and arch-dependent, every erlang package should be installed into %{libdir}/erlang which makes every erlang package arch-dependent.
A few items before I review this: (There are no erlang packaging guidelines that I'm aware of, so some of what I'm asking might be stuff that belongs in erlang packaging guidelines) * Why are you disabling debuginfo? * With the erlang split, is BuildRequires: erlang really appropriate? What about Requires: erlang? If possible, this should be limited to the required erlang subpackages only. * The license is not BSD, it is MIT. Also, the source code contains no license attribution, you should ask upstream to add it. * It is not necessary to set BuildRoot or delete it during %install anymore, see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (EPEL 4 and 5 still require it, but if you're not planning on building for those targets, you can remove these lines)
(In reply to comment #2) > * Why are you disabling debuginfo? I switched it off just to be sure that no bogus empty *-debuginfo subpackage will be produced. I just checked and it seems that I don't need to explicitly disable it. > * With the erlang split, is BuildRequires: erlang really appropriate? What > about Requires: erlang? If possible, this should be limited to the required > erlang subpackages only. Yes, definitely. I will try to build exact list of dependencies for this (and other) package(s). However, automatic dependency generator for Erlang provides too much data => I had to disable it in Fedora until we find more suitable solution => it will costs me few hours to create list of dependencies. > * The license is not BSD, it is MIT. Ok, fixed. > Also, the source code contains no license > attribution, you should ask upstream to add it. Ok, I will ask. Hope that this is not a blocker. > * It is not necessary to set BuildRoot or delete it during %install anymore, > see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (EPEL 4 > and 5 still require it, but if you're not planning on building for those > targets, you can remove these lines) Yes - I plan to push it to EPEL as well, so I need to keep some obsoleted packaging stuff. I will provide updated package very soon.
Okay, so the proper per-file licensing is not a blocker, just please try to get upstream to do it. Show me a new package that has the proper dependencies (you don't have to get the automatic dependency generator working here, just hardcode the correct minimum dependencies) and doesn't disable the debuginfo and I'll finish out the review.
*Almost* done: http://peter.fedorapeople.org/erlang-oauth.spec http://peter.fedorapeople.org/erlang-oauth-0-0.2.gite8aecf0.fc12.src.rpm Unfortunately I was wrong previously - I can't remove "%global debug_package %{nil}" because it does produces empty *-debuginfo w/o this line.
Ah, okay. So that is definitely something we should write up as Packaging Guidelines for erlang (or, if possible, fix so that there is useful debuginfo). === REVIEW === Good: - rpmlint checks return: erlang-oauth.src: W: invalid-url Source0: erlang-oauth-0.gite8aecf0.tar.bz2 erlang-oauth.x86_64: E: explicit-lib-dependency erlang-stdlib erlang-oauth.x86_64: E: no-binary erlang-oauth.x86_64: W: only-non-binary-in-usr-lib All are safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, source is missing license attribution, but upstream has been notified - spec file legible, in am. english - source matches upstream (can't do tarball comparison because it is generated from git, but diff of checkout and source matches) - package compiles on F-13 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file This is APPROVED. One extremely minor suggestion: In the comments on how to make the source tarball from the git repo, you reference "%{git_commit}", but you don't actually define it in the spec anywhere. It would be nice if you would do that, or at least, remove it from the comments so it doesn't confuse anyone. P.S. I'd love a review on 566560.
Thanks!
New Package CVS Request ======================= Package Name: erlang-oauth Short Description: An Erlang OAuth implementation Owners: peter Branches: F-11 F-12 F-13 EL-6 EL-5 EL-4 InitialCC:
CVS Done
couchdb-0.10.2-4.fc11,erlang-oauth-0-0.3.gite8aecf0.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc11,erlang-oauth-0-0.3.gite8aecf0.fc11
couchdb-0.10.2-4.fc12,erlang-oauth-0-0.3.gite8aecf0.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc12,erlang-oauth-0-0.3.gite8aecf0.fc12
couchdb-0.10.2-4.el5,erlang-oauth-0-0.3.gite8aecf0.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.el5,erlang-oauth-0-0.3.gite8aecf0.el5
couchdb-0.10.2-4.fc13,erlang-oauth-0-0.3.gite8aecf0.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc13,erlang-oauth-0-0.3.gite8aecf0.fc13
couchdb-0.10.2-4.fc12, erlang-oauth-0-0.3.gite8aecf0.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc12,erlang-oauth-0-0.3.gite8aecf0.fc12
couchdb-0.10.2-4.fc11, erlang-oauth-0-0.3.gite8aecf0.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc11,erlang-oauth-0-0.3.gite8aecf0.fc11
couchdb-0.10.2-4.fc13, erlang-oauth-0-0.3.gite8aecf0.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb erlang-oauth'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-4.fc13,erlang-oauth-0-0.3.gite8aecf0.fc13
erlang-oauth-0-0.4.gite8aecf0.fc12,couchdb-0.10.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc12,couchdb-0.10.2-4.fc12
erlang-oauth-0-0.4.gite8aecf0.fc11,couchdb-0.10.2-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc11,couchdb-0.10.2-4.fc11
erlang-oauth-0-0.4.gite8aecf0.el5,couchdb-0.10.2-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.el5,couchdb-0.10.2-4.el5
erlang-oauth-0-0.4.gite8aecf0.fc13,couchdb-0.10.2-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc13,couchdb-0.10.2-4.fc13
erlang-oauth-0-0.4.gite8aecf0.fc11, couchdb-0.10.2-4.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-oauth couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc11,couchdb-0.10.2-4.fc11
erlang-oauth-0-0.4.gite8aecf0.fc13, couchdb-0.10.2-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-oauth couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc13,couchdb-0.10.2-4.fc13
erlang-oauth-0-0.4.gite8aecf0.fc12, couchdb-0.10.2-4.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-oauth couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.fc12,couchdb-0.10.2-4.fc12
erlang-oauth-0-0.4.gite8aecf0.el5, couchdb-0.10.2-4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-oauth couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-oauth-0-0.4.gite8aecf0.el5,couchdb-0.10.2-4.el5
erlang-oauth-0-0.4.gite8aecf0.fc11, couchdb-0.10.2-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
erlang-oauth-0-0.4.gite8aecf0.fc13, couchdb-0.10.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
erlang-oauth-0-0.4.gite8aecf0.fc12, couchdb-0.10.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
erlang-oauth-0-0.4.gite8aecf0.el5, couchdb-0.10.2-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.