Bug 58146 - dhcpcd still remove IFF_MULTICAST from interface flags
Summary: dhcpcd still remove IFF_MULTICAST from interface flags
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: dhcpcd   
(Show other bugs)
Version: 7.2
Hardware: i386
OS: Linux
Target Milestone: ---
Assignee: Elliot Lee
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2002-01-09 22:23 UTC by Tim Wright
Modified: 2008-05-01 15:38 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2002-01-15 23:46:43 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch to client.c to fix interface manipulation. (1.58 KB, patch)
2002-01-15 23:42 UTC, Tim Wright
no flags Details | Diff

Description Tim Wright 2002-01-09 22:23:40 UTC
Description of Problem: This is ongoing from bug #55093. I just took the rawhide 
RPM which claims to have fixed bug #55093, and it still fails turning off multicast for 
the interface in question. Looking at the code, this makes sense because at line 
1175, IFF_MULTICAST is added to the interface flags, but almost immediately 
after at line 1206 in the broadcast loop, it's missing again :-(

I'm not sure, but it strikes me that it would be better to use SIOCGIFFLAGS first 
and save such things as the multicast state rather than unconditionally overwriting 
the flags.

Version-Release number of selected component (if applicable):

How Reproducible:

Steps to Reproduce:
1.  Install rawhide dhcpcd
2. Bring up an interface using dhcpcd
3. Notice that multicast is no longer set on the interface

Actual Results:
Interface does not show multicast.

Expected Results:
Interface should show multicast.

Additional Information:
 This worked in Red Hat 7.1. The wierd part is that the 1.3.18pl8 code doesn't 
seem to bother with the IFF_MULTICAST flag at all, yet it doesn't get reset. Is this 
a change in the library/kernel code that's now killing the flag ?

Comment 1 Tim Wright 2002-01-15 23:42:47 UTC
Created attachment 42516 [details]
Patch to client.c to fix interface manipulation.

Comment 2 Tim Wright 2002-01-15 23:46:38 UTC
Attached patch that fixes the problem with the flags getting reset, at least in
my testing. This patch is against the virgin dhcpcd-1.3.21pl2 code.



Comment 3 Elliot Lee 2002-03-08 16:02:32 UTC
applied in my package, will submit upstream as well

Note You need to log in before you can comment on or make changes to this bug.