Bug 584100 - prlink.h gives warning with -Wstrict-prototypes
Summary: prlink.h gives warning with -Wstrict-prototypes
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: nss
Version: 4.9
Hardware: All
OS: Linux
high
low
Target Milestone: rc
: ---
Assignee: Elio Maldonado Batiz
QA Contact: BaseOS QE Security Team
URL:
Whiteboard:
Depends On: 453577
Blocks: 624751 625015
TreeView+ depends on / blocked
 
Reported: 2010-04-20 18:57 UTC by Chris Feist
Modified: 2012-06-20 16:03 UTC (History)
5 users (show)

Fixed In Version: nss-3.12.6-2.el4
Doc Type: Bug Fix
Doc Text:
Clone Of: 453577
: 624751 (view as bug list)
Environment:
Last Closed: 2012-06-20 16:03:45 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Chris Feist 2010-04-20 18:57:57 UTC
+++ This bug was initially created as a clone of Bug #453577 +++

Version-Release number of selected component (if applicable):
nspr-devel-4.7.0.99.2-1.el5

for test case and patch see original bug

+++ This bug was initially created as a clone of Bug #451616 +++

Description of problem:
Using nspr header gives a warning in the prlink.h file when -Wstrict-prototypes
is included in the CFLAGS. And when -Werror is used, then it is not possible to
compile at all.

Version-Release number of selected component (if applicable):
nspr-devel-4.6.7-3.fc8
but the header was not changed since Apr/06/2006, so all current Fedora and RHEL
versions are affected.

How reproducible:
100%

Steps to Reproduce:
1. run the script from attachments
  
Actual results:
In file included from /usr/include/nspr4/nspr.h:55,
                 from nspr-test.c:2:
/usr/include/nspr4/prlink.h:52: warning: function declaration isn’t a prototype
/usr/include/nspr4/prlink.h:209: warning: function declaration isn’t a prototype


Expected results:
No warnings

Additional info:
There was a thread in gcc mailing list about the meaning of the warning -
http://gcc.gnu.org/ml/gcc-help/2006-07/msg00033.html

-- Additional comment from dan on 2008-06-16 04:04 EST --
Created an attachment (id=309468)
test case


-- Additional comment from dan on 2008-06-16 04:08 EST --
Created an attachment (id=309471)
patch to remove the warnings

--- Additional comment from ccaulfie on 2010-04-08 10:56:55 EDT ---

This bug is preventing us building cluster packages for RHEL5. I don't see why we should have to change our compiler flags to work around a bug in a library. Especially as it seems to have been recently (re)introduced.

Comment 1 Chris Feist 2010-04-20 18:58:24 UTC
This bug is also present on RHEL4, preventing cluster packages from building for 4.9.  Is there any ETA for when (if?) this bug will be fixed?

Comment 2 Kai Engert (:kaie) (inactive account) 2010-04-22 15:10:51 UTC
The upstream bug has been proposed as WONTFIX.

Upstream is worried this patch may break source compatibility.

Either we ignore this warning or we must carry a patch in the NSPR package.

Comment 3 Elio Maldonado Batiz 2010-04-22 16:22:06 UTC
Openswan 2.6.24 also ran into this problem and the work-around was to selectively add 'CFLAGS+=-Wno-strict-prototypes' in the affected places, see http://lists.openswan.org/pipermail/commits/2010-January/001672.html
We opted for the workaround rather than potentially breaking source compatibility promises. For the Mozilla upstream bug see: 
https://bugzilla.mozilla.org/show_bug.cgi?id=410677

Comment 4 Elio Maldonado Batiz 2010-04-27 14:37:22 UTC
See https://bugzilla.redhat.com/attachment.cgi?id=409353
that patch should solve this bug.

Comment 8 RHEL Program Management 2010-05-11 00:07:43 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 14 Jiri Pallich 2012-06-20 16:03:45 UTC
Thank you for submitting this issue for consideration in Red Hat Enterprise Linux. The release for which you requested us to review is now End of Life. 
Please See https://access.redhat.com/support/policy/updates/errata/

If you would like Red Hat to re-consider your feature request for an active release, please re-open the request via appropriate support channels and provide additional supporting details about the importance of this issue.


Note You need to log in before you can comment on or make changes to this bug.