Bug 453577
| Summary: | prlink.h gives warning with -Wstrict-prototypes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Dan Horák <dhorak> | ||||||||
| Component: | nss | Assignee: | Elio Maldonado Batiz <emaldona> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | BaseOS QE Security Team <qe-baseos-security> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | 5.2 | CC: | amarecek, bstein, ccaulfie, ebenes, emaldona, kengert, notting, ohudlick, rrelyea, syeghiay, tis | ||||||||
| Target Milestone: | rc | Keywords: | ZStream | ||||||||
| Target Release: | 5.6 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | |||||||||||
| : | 584100 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2011-06-02 17:19:23 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 575157, 584100, 587546, 590145, 590728, 590734, 624751 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dan Horák
2008-07-01 13:09:27 UTC
This bug is preventing us building cluster packages for RHEL5. I don't see why we should have to change our compiler flags to work around a bug in a library. Especially as it seems to have been recently (re)introduced. (In reply to comment #1) > This bug is preventing us building cluster packages for RHEL5. It's just a warning, do you abort your builds for any warnings? > I don't see why > we should have to change our compiler flags to work around a bug in a library. > Especially as it seems to have been recently (re)introduced. The upstream bug has been proposed as WONTFIX. Upstream is worried this patch may break source compatibility. Either we ignore this warning or we must carry a patch in the NSPR package. Created attachment 408383 [details] Build output This is a typescript output of building cman (specifically fence_xvm part, which uses nss/nspr) with gcc-4.1.2-48.el5 from RHEL 5.5 Build 1: - older nss/nspr from 5.4 installed (WORKS) Build 2: - newer nspr installed from http://rhn.redhat.com/errata/RHSA-2010-0165.html (WORKS) Build 3: - newer nss installed from http://rhn.redhat.com/errata/RHSA-2010-0165.html (FAILS) I looked at prlink.h - historically, the function pointer has been that way for many years. I think this is not a new bug in nspr, but it was made visible by a change in nss with the update from nss-3.12.3.99.3-1.el5_3.2 to nss-3.12.6-1.el5_4.x86_64.rpm. If I had to guess, I would suppose the #includes in nss changed. In Bug 451616 the following fix has been proposed for the the nspr header wich has function protopyes which aren't strict ansi. --- prlink.h.orig 2008-06-16 09:33:28.000000000 +0200 +++ prlink.h 2008-06-16 09:33:58.000000000 +0200 @@ -49,7 +49,7 @@ typedef struct PRStaticLinkTable { const char *name; - void (*fp)(); + void (*fp)(void); } PRStaticLinkTable; /* @@ -206,7 +206,7 @@ ** ** This function does not modify the reference count of the library. */ -typedef void (*PRFuncPtr)(); +typedef void (*PRFuncPtr)(void); NSPR_API(PRFuncPtr) PR_FindFunctionSymbol(PRLibrary *lib, const char *name); The problem is that if we were to apply this fix we could potentially break existing code and we want to preserve in fedora and RHEL the compatibility guarantees from upstream nss and nspr from upstream. Created attachment 409322 [details]
prevents nspr's prink.h from getting indirectly included by nss clients
An nss scratch build is avaiable at https://brewweb.devel.redhat.com/taskinfo?taskID=2403399 (In reply to comment #8) Ignore this build, it's not good. A corrected patch and build coming next. Created attachment 409353 [details]
Patch V2, secmod doesn't include prlink.h
(In reply to comment #9) New scratch build https://brewweb.devel.redhat.com/taskinfo?taskID=2403527 Those RPMs fix the cluster build. |