Bug 593879 - Review Request: libvpx - VP8 Video Codec SDK
Review Request: libvpx - VP8 Video Codec SDK
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dennis Gilmore
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-19 18:36 EDT by Tom "spot" Callaway
Modified: 2014-12-05 06:01 EST (History)
15 users (show)

See Also:
Fixed In Version: libvpx-0.9.0-5.fc12
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-05-24 15:32:14 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
dennis: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2010-05-19 18:36:23 EDT
Spec URL: http://auroralinux.org/people/spot/review/new/libvpx.spec
SRPM URL: http://auroralinux.org/people/spot/review/new/libvpx-0.9.0-1.f13.src.rpm
Description: 
libvpx provides the VP8 SDK, which allows you to integrate your applications
with the VP8 video codec, a high quality, royalty free, open source codec
deployed on millions of computers and devices worldwide.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2198341

(Packager note: This thing has a really atrocious buildsystem, and the spec attempts to work around it, rather than trying to repair it to work properly. There is only so much duct tape you can put on something before it just becomes a giant ball of duct tape. Also, note that because the asm code doesn't want to be part of a shared library, this package is built using only the generic files for the time being.)
Comment 1 Tom "spot" Callaway 2010-05-19 18:41:35 EDT
Actual SRPM: http://www.auroralinux.org/people/spot/review/new/libvpx-0.9.0-1.fc13.src.rpm
Comment 2 Dennis Gilmore 2010-05-19 19:00:32 EDT
rpmlint /var/lib/mock/fedora-13-x86_64/result
libvpx-utils.x86_64: W: no-documentation
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/vp8_scalable_patterns 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/twopass_vp8_encoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/decode_to_md5 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/vp8cx_set_ref 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/force_keyframe 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/example_xma 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/postproc 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/decode_with_drops 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/error_resilient 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/simple_vp8_encoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/ivfenc 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/simple_vp8_decoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/ivfdec 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/vp8_set_maps 0775L
libvpx.src: W: spelling-error %description -l en_US codec -> codex, code, codes
libvpx.src:51: W: rpm-buildroot-usage %build DIST_DIR=%{buildroot} ./configure --target=generic-gnu --enable-pic --disable-optimizations --enable-debug
libvpx.src:51: W: configure-without-libdir-spec
libvpx.src: W: no-cleaning-of-buildroot %install
libvpx.src: W: no-buildroot-tag
libvpx.src: W: invalid-url Source0: http://webm.googlecode.com/files/libvpx-0.9.0.tar.bz2 HTTP Error 404: Not Found
libvpx.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes
5 packages and 0 specfiles checked; 14 errors, 8 warnings.


permissions we should fix
 
i think that rather than doing the rename of the utils to 
/usr/bin/simple_vp8_decoder
/usr/bin/simple_vp8_encoder
/usr/bin/twopass_vp8_encoder

we should name them 
/usr/bin/vp8_simple_decoder
/usr/bin/vp8_simple_encoder
/usr/bin/vp8_twopass_encoder

which is consistent with some of the other included utils namely 

/usr/bin/vp8_scalable_patterns
/usr/bin/vp8_set_maps

upstream source matches
sha256sum fedora/SOURCES/libvpx-0.9.0.tar.bz2 Download/libvpx-0.9.0.tar.bz2 
a0096ac6859cfb61cf06dd9bc0a79a3333a4ec389ba311911d84df8ff2a1b9dc  fedora/SOURCES/libvpx-0.9.0.tar.bz2
a0096ac6859cfb61cf06dd9bc0a79a3333a4ec389ba311911d84df8ff2a1b9dc  Download/libvpx-0.9.0.tar.bz2


builds fine in mock

SPEC is clear and legible
Comment 3 Tom "spot" Callaway 2010-05-20 08:47:22 EDT
Permissions fixed.
Binaries renamed, as suggested.
Also fixed some missing weak symbols in the shared library.

New SRPM: http://www.auroralinux.org/people/spot/review/new/libvpx-0.9.0-2.fc13.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/libvpx.spec
Comment 4 Bastien Nocera 2010-05-20 09:25:56 EDT
Does this need to go through legal?
Comment 5 Christian Schaller 2010-05-20 10:58:08 EDT
Maybe trivial point, but the GStreamer plugins for vp8 is currently looking for the header files in include/vp8. Maybe that is a 'cleaner' way of storing them than just dropping them in include.
Comment 6 Christian Schaller 2010-05-20 11:03:36 EDT
Sorry, I mean in include/vpx
Comment 7 Tom "spot" Callaway 2010-05-20 11:48:15 EDT
(In reply to comment #4)
> Does this need to go through legal?    

It has been through legal, and there are no blockers at this time.
Comment 8 Tom "spot" Callaway 2010-05-20 12:26:26 EDT
New package:

* Header files in include/vpx    
* pkgconfig file for libvpx
* Optimized now (thanks to debian for figuring out how to glue the shared lib together)

New SRPM:
http://www.auroralinux.org/people/spot/review/new/libvpx-0.9.0-3.fc13.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/libvpx.spec
Comment 9 Adel Gadllah 2010-05-20 12:31:26 EDT
(In reply to comment #8)
> New package:
> 
> * Header files in include/vpx    
> * pkgconfig file for libvpx
> * Optimized now (thanks to debian for figuring out how to glue the shared lib
> together)
> 
> New SRPM:
> http://www.auroralinux.org/people/spot/review/new/libvpx-0.9.0-3.fc13.src.rpm
> New SPEC: http://www.auroralinux.org/people/spot/review/new/libvpx.spec    

# If/when we build an optimized version that uses the asm, we'll need this.
# BuildRequires: yasm
[...]
%changelog
* Thu May 20 2010 Tom "spot" Callaway <tcallawa@redhat.com> 0.9.0-3
- add pkg-config file
- move headers into include/vpx/
- enable optimization

Something does not look right here ;)
Comment 10 Tom "spot" Callaway 2010-05-20 12:39:29 EDT
Yep. That's definitely not right. Fixed in -4:

New SRPM:
http://www.auroralinux.org/people/spot/review/new/libvpx-0.9.0-4.fc13.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/libvpx.spec
Comment 11 Matěj Cepl 2010-05-20 13:39:42 EDT
johanka:build$ LANG=C rpmbuild --rebuild RHEL6/libvpx-0.9.0-4.fc13.src.rpm 
Installing RHEL6/libvpx-0.9.0-4.fc13.src.rpm
error: Failed build dependencies:
	php-cli is needed by libvpx-0.9.0-4.el6.x86_64
johanka:build$ 

Just curious: php-cli for video codec? Is it right?
Comment 12 Tom "spot" Callaway 2010-05-20 13:42:16 EDT
No, its not sane, but yes, it is correct. :)
Comment 13 Benjamin Otte 2010-05-20 15:35:48 EDT
It uses php for the documentation. Apparently doxygen alone is not enough of a beast.

Just wanted to note that I'm happy with the package, GStreamer builds fine, Youtube videos play and use as little CPU as they should.
Comment 14 Dennis Gilmore 2010-05-20 17:13:58 EDT
rpmlint /var/lib/mock/fedora-13-x86_64/result
libvpx-utils.x86_64: W: no-documentation
libvpx.src: W: spelling-error %description -l en_US codec -> codex, code, codes
libvpx.src:56: W: configure-without-libdir-spec
libvpx.src: W: no-cleaning-of-buildroot %install
libvpx.src: W: no-buildroot-tag
libvpx.src: W: invalid-url Source0: http://webm.googlecode.com/files/libvpx-0.9.0.tar.bz2 HTTP Error 404: Not Found
libvpx.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes
5 packages and 0 specfiles checked; 0 errors, 7 warnings.


I did download the source from the url and it matched rpmlint seems to have a bug

Approved
Comment 15 Tom "spot" Callaway 2010-05-21 07:48:36 EDT
New Package CVS Request
=======================
Package Name: libvpx
Short Description: VP8 Video Codec SDK
Owners: spot
Branches: F-11 F-12 F-13 devel
InitialCC:
Comment 16 Dennis Gilmore 2010-05-21 11:11:08 EDT
CVS Done
Comment 17 Fedora Update System 2010-05-21 17:35:01 EDT
libvpx-0.9.0-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc12
Comment 18 Fedora Update System 2010-05-21 17:35:06 EDT
libvpx-0.9.0-5.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc13
Comment 19 Fedora Update System 2010-05-21 17:35:11 EDT
libvpx-0.9.0-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc11
Comment 20 Fedora Update System 2010-05-24 15:32:09 EDT
libvpx-0.9.0-5.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 21 Fedora Update System 2010-05-24 15:44:06 EDT
libvpx-0.9.0-5.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 22 Fedora Update System 2010-05-24 15:45:37 EDT
libvpx-0.9.0-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 23 Tom "spot" Callaway 2010-09-01 11:18:41 EDT
Package Change Request
======================
Package Name: libvpx
New Branches: el5 el6
Owners: spot
Comment 24 Kevin Fenzi 2010-09-01 15:29:20 EDT
Git done (by process-git-requests).
Comment 25 Jiri Kastner 2014-12-04 06:05:17 EST
Package Change Request
======================
Package Name: libvpx
New Branches: epel7
Owners: spot
Comment 26 Peter Robinson 2014-12-04 06:14:35 EST
(In reply to Jiri Kastner from comment #25)
> Package Change Request
> ======================
> Package Name: libvpx
> New Branches: epel7
> Owners: spot

Why are we requesting an epel7 branch for a package that is in main EL7 distro? Has the policy changed?
Comment 27 Jiri Kastner 2014-12-05 06:01:55 EST
(In reply to Peter Robinson from comment #26)
> Why are we requesting an epel7 branch for a package that is in main EL7
> distro? Has the policy changed?

mea culpa, i checked only koji for epel7 build

Note You need to log in before you can comment on or make changes to this bug.