Bug 597246 - ContentManagerBean slurps entire content in-memory
Summary: ContentManagerBean slurps entire content in-memory
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Content
Version: 1.3
Hardware: All
OS: All
high
high vote
Target Milestone: ---
: ---
Assignee: Simeon Pinder
QA Contact: Corey Welton
URL:
Whiteboard:
Depends On:
Blocks: jon24-content jon-sprint11-bugs
TreeView+ depends on / blocked
 
Reported: 2010-05-28 13:50 UTC by John Mazzitelli
Modified: 2010-08-12 16:51 UTC (History)
2 users (show)

Fixed In Version: 2.4
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-08-12 16:51:45 UTC


Attachments (Terms of Use)

Description John Mazzitelli 2010-05-28 13:50:00 UTC
org.rhq.enterprise.server.content.ContentManagerBean.getUploadedPackageVersion and createPackageVersion both slurp the entire input stream in memory in order to store the bits in the database PackageBits table. We need to refactor these two methods to stream properly to the database.

Comment 1 Simeon Pinder 2010-06-25 20:31:49 UTC
This has been addressed and I added a unit test to ContentUIManagerBeanTest to exercise Blob read/write via streaming.

Commit hash(es):
6f4eb034b12085258f98c92713af8a499ea78261
17b0f8bb1a60583a0d1ea24bd894cc9a3dbd5c42
863201f8b91e01632ec7453940f4b08fd3d0dda7
8bbfe126b897a21135b21987aefcce1b45e76cb3
408bc20049ff0f06738e70b2dbafdbbd83366fdb

No real way to QA this, just verify that no regression in delivered content functionality.

Comment 2 Simeon Pinder 2010-06-25 20:32:44 UTC
Available in successful release builds >= 71.

Comment 3 Charles Crouch 2010-06-30 17:26:20 UTC
Reducing priority to clarify QA testing order

Comment 4 Corey Welton 2010-07-06 12:49:26 UTC
QA Verified/Closing - no regressions found.

Comment 5 Corey Welton 2010-08-12 16:51:45 UTC
Mass-closure of verified bugs against JON.


Note You need to log in before you can comment on or make changes to this bug.