Spec URL: http://rpms.damian.net/SPECS/php-channel-deepend.spec SRPM URL: http://rpms.damian.net/SRPMS/php-channel-deepend-1.3-1.fc12.src.rpm Description: Survive The Deep End PEAR Channel
REVIEW * no source files (channel.xml match latest upstream) * package meets naming * package must meet packaging guidelines * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license (of the packages provided by the channel). * license is open source-compatible (BSD). * BuildRequires are proper. * %clean is present. * package builds in mock (F-13). * package installs properly * channel (un)registered properly * rpmlint (warnings are ok) : $ rpmlint -v php-channel-deepend.spec /home/extras/SRPMS/php-channel-deepend-1.3-1.fc13.src.rpm /home/extras/RPMS/noarch/php-channel-deepend-1.3-1.fc13.noarch.rpm php-channel-deepend.spec: I: checking-url http://pear.survivethedeepend.com/channel.xml (timeout 10 seconds) php-channel-deepend.src: I: checking php-channel-deepend.src: I: checking-url http://www.survivethedeepend.com/ (timeout 10 seconds) php-channel-deepend.src: I: checking-url http://pear.survivethedeepend.com/channel.xml (timeout 10 seconds) php-channel-deepend.noarch: I: checking php-channel-deepend.noarch: I: checking-url http://www.survivethedeepend.com/ (timeout 10 seconds) php-channel-deepend.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. * final provides are sane: php-channel(pear.survivethedeepend.com) = 1.3 php-channel-deepend = 1.3-1.fc13 + final requires /usr/bin/pear php-pear(PEAR) * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation * %install start with rm * %clean ok Just a note, As I hate wilcards in %file, I will prefer %{pear_xmldir}/%{name}.xml *** APPROVED ***
(In reply to comment #1) > Just a note, As I hate wilcards in %file, I will prefer > %{pear_xmldir}/%{name}.xml > > *** APPROVED *** Thanks. I keep that in mind for the first update. New Package CVS Request ======================= Package Name: php-channel-deepend Short Description: Survive The Deep End PEAR Channel Owners: cdamian Branches: F-13 EL-6 InitialCC:
CVS done (by process-cvs-requests.py).
php-channel-deepend-1.3-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/php-channel-deepend-1.3-2.fc13
php-channel-deepend-1.3-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-channel-deepend'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-channel-deepend-1.3-2.fc13
php-channel-deepend-1.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.