Spec URL: http://rpms.damian.net/SPECS/php-deepend-Mockery.spec SRPM URL: http://rpms.damian.net/SRPMS/php-deepend-Mockery-0.6.0-1.fc12.src.rpm Description: Mockery is a simple but flexible PHP mock object framework for use in unit testing. It is inspired by Ruby's flexmock and Java's Mockito, borrowing elements from both of their APIs.
Could you please update to the latest version (0.6.3) for review ? First notes: BuildRequires: php-pear >= 1:1.4.0 Must be 1:1.4.9-1.2 (which is the first version in fedora with the needed macros)
(In reply to comment #1) > Could you please update to the latest version (0.6.3) for review ? > > First notes: > > BuildRequires: php-pear >= 1:1.4.0 > Must be 1:1.4.9-1.2 (which is the first version in fedora with the needed > macros) both done: Spec URL: http://rpms.damian.net/SPECS/php-deepend-Mockery.spec SRPM URL: http://rpms.damian.net/SRPMS/php-deepend-Mockery-0.6.3-1.fc13.src.rpm
=== FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: F-13 x86_64 [x] Rpmlint output: php-deepend-Mockery.spec: I: checking-url http://pear.survivethedeepend.com/get/Mockery-0.6.3.tgz (timeout 10 seconds) php-deepend-Mockery.src: I: checking php-deepend-Mockery.src: W: spelling-error %description -l en_US flexmock -> flex mock, flex-mock, flexuous php-deepend-Mockery.src: I: checking-url http://github.com/padraic/mockery (timeout 10 seconds) php-deepend-Mockery.src: I: checking-url http://pear.survivethedeepend.com/get/Mockery-0.6.3.tgz (timeout 10 seconds) php-deepend-Mockery.noarch: I: checking php-deepend-Mockery.noarch: W: spelling-error %description -l en_US flexmock -> flex mock, flex-mock, flexuous php-deepend-Mockery.noarch: W: incoherent-version-in-changelog 0.6.0-1 ['0.6.3-1.fc13', '0.6.3-1'] php-deepend-Mockery.noarch: I: checking-url http://github.com/padraic/mockery (timeout 10 seconds) php-deepend-Mockery.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 4 warnings. [x] Package is not relocatable. [x] Buildroot is correct Used : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: BSD [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : e3c24179ba0d99862a4ac74d82206d37 Mockery-0.6.3.tgz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final requires /usr/bin/pear php-channel(pear.survivethedeepend.com) php-common >= 5.3.2 [x] Final provides php-pear(pear.survivethedeepend.com/Mockery) = 0.6.3 php-deepend-Mockery = 0.6.3-1.fc13 === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji dist-f14 scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2346146 [-] Package should compile and build into binary rpms on all supported architectures. Tested on: [-] Package functions as described. [x] Scriptlets must be sane, if used. (un)register the extension : ok [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [-] %check is present and the tests pass No doc / license provided by upstream in the tarball, but are available on github. http://github.com/padraic/mockery/blob/master/LICENSE http://github.com/padraic/mockery/blob/master/README.markdown Should be usefull to ask upstream to include this files in the tarball for next release, and/or add them in the package *** APPROVED ***
Thanks for the review. I contacted upstream about the doc files and will include them in my first update myself. New Package CVS Request ======================= Package Name: php-deepend-Mockery Short Description: Mockery is a simple but flexible PHP mock object framework Owners: cdamian Branches: F-13 EL-6 InitialCC:
CVS done (by process-cvs-requests.py).
php-deepend-Mockery-0.6.3-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/php-deepend-Mockery-0.6.3-2.fc13
php-deepend-Mockery-0.6.3-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-deepend-Mockery'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-deepend-Mockery-0.6.3-2.fc13
php-deepend-Mockery-0.6.3-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: php-deepend-Mockery New Branches: epel7 Owners: cdamian ignatenkobrain siwinski
Git done (by process-git-requests).