Bug 598361 - Review Request: maven-rar-plugin - Maven Rar plugin
Summary: Review Request: maven-rar-plugin - Maven Rar plugin
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-01 08:08 UTC by Yong Yang
Modified: 2010-06-12 10:09 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-06-12 10:09:27 UTC
Type: ---
Embargoed:
sochotni: fedora-review+


Attachments (Terms of Use)

Description Yong Yang 2010-06-01 08:08:14 UTC
Spec URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin.spec
SRPM URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin-2.2-1.src.rpm
Description: A resource adapter is a system-level software driver that a Java application uses to connect to an enterprise information system (EIS). The RAR plugin has the capability to store these resource adapters to an archive (Resource Adapter Archive or RAR) which can be deployed to a J2EE server.

Comment 1 Stanislav Ochotnicky 2010-06-01 13:57:04 UTC
I can do the review.

Comment 2 Stanislav Ochotnicky 2010-06-02 08:48:03 UTC
NEEDSWORK: rpmlint must be run on every package. The output should be posted in the review.
maven-rar-plugin.src: E: description-line-too-long C A resource adapter is a system-level software driver that a Java application uses to
maven-rar-plugin.src: E: description-line-too-long C connect to an enterprise information system (EIS). The RAR plugin has the capability to
maven-rar-plugin.src: E: description-line-too-long C store these resource adapters to an archive (Resource Adapter Archive or RAR) which can be deployed to a J2EE server.
maven-rar-plugin.src: W: invalid-url Source0: maven-rar-plugin-2.2.tar.gz
maven-rar-plugin.noarch: E: description-line-too-long C A resource adapter is a system-level software driver that a Java application uses to
maven-rar-plugin.noarch: E: description-line-too-long C connect to an enterprise information system (EIS). The RAR plugin has the capability to
maven-rar-plugin.noarch: E: description-line-too-long C store these resource adapters to an archive (Resource Adapter Archive or RAR) which can be deployed to a J2EE server.
maven-rar-plugin.noarch: W: no-documentation
maven-rar-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-rar-plugin
3 packages and 0 specfiles checked; 6 errors, 3 warnings.

Fix those long lines please

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.  .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. 
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. 
OK: Each package must consistently use macros.

But :-) It's possible to condense 2 calls of install from:
install -d -m 0755 %{buildroot}%{_javadir}
install -m 644 target/%{name}-%{version}.jar   %{buildroot}%{_javadir}/%{name}-%{version}.jar

to (this will create dest dir automatically):
install -Dpm 644 target/%{name}-%{version}.jar   %{buildroot}%{_javadir}/%{name}-%{version}.jar

It's just a suggestion though...

(and yes I copy-pasted this from the other review I made for your
maven plugin :-) )

OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). 
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. 
OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 
OK: All filenames in rpm packages must be valid UTF-8. 


Other notes/problems:
* You need to obsolete version 0:2.0.8 and provide 1:%{version}-%{release}
  your obsoletes would not obsolete current version of rar plugin.
* It would be good to put comment why test failure is ignored. It
  would be good to put comment why test failure is ignored. I
  investigated a bit. The plugin compiles with with mvn, but fails with
  mvn-jpp. I gave up on finding exact cause, but putting comment in the
  spec file so that someone can look at it when he/she has time would be
  good
* Use at least bz2 compression (ideally xz)

Comment 3 Yong Yang 2010-06-03 08:33:32 UTC
Spec URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin.spec
SRPM URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin-2.2-2.src.rpm

Please review again, changlog:
- Format description 
- Fix Obsoletes and Provides
- Use bz2 to compress source
- Add reason for ignore failure of test

Comment 4 Stanislav Ochotnicky 2010-06-03 12:19:53 UTC
Package looks OK. Two small things though:
 * spelling error (applicationuses - quite funny looking to me :-) )
 * please update comment about Source0 to actually create tar.bz2 format ('j' instead of 'z' and proper suffix)

All in all, those issues are cosmetic. Package is APPROVED.

Comment 5 Yong Yang 2010-06-04 02:44:44 UTC
Thanks.The typo is funny :), applicationuses = application + uses, should be caused by a problem of cursor position.

This is the latest version of SPEC and SRPM:
Spec URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin.spec
SRPM URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin-2.2-3.src.rpm

Comment 6 Yong Yang 2010-06-04 03:10:52 UTC
New Package CVS Request
=======================
Package Name: maven-rar-plugin
Short Description: Plugin to create Resource Adapter Archive which can be deployed to a J2EE server
Owners: yyang
Branches: devel
InitialCC: huwang liweinan akurtako dbhole

Comment 7 Kevin Fenzi 2010-06-07 21:27:34 UTC
cvs done, except liweinan account doesn't exist.

Comment 8 Yong Yang 2010-06-09 05:50:32 UTC
Hi Kevin, cvs is not done yet, may be caused by wrong CC, please create cvs again and leave CC blank, thanks.

New Package CVS Request
=======================
Package Name: maven-rar-plugin
Short Description: Plugin to create Resource Adapter Archive which can be
deployed to a J2EE server
Owners: yyang
Branches: devel
InitialCC:

Comment 9 Kevin Fenzi 2010-06-11 04:52:47 UTC
Try now. I think it's complete.


Note You need to log in before you can comment on or make changes to this bug.