Spec URL: http://sites.google.com/site/gracca/gtk-chtheme.spec SRPM URL: http://sites.google.com/site/gracca/gtk-chtheme-0.3.1-3.fc13.src.rpm Description: As the name suggests, this little program lets you change your Gtk+ 2.0 theme. The aim is to make theme preview and selection as slick as possible. Themes installed on the system are presented for selection and previewed on the fly. A large variety of widgets provides a comprehensive demonstration. $ rpmlint SPECS/gtk-chtheme.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/gtk-chtheme-0.3.1-3.fc13.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/i686/gtk-chtheme-0.3.1-3.fc13.i686.rpm gtk-chtheme.i686: W: unstripped-binary-or-object /usr/bin/gtk-chtheme gtk-chtheme.i686: W: spurious-executable-perm /usr/share/man/man1/gtk-chtheme.1.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fabian, you said in Bug 541724 that it is not necessary to change the attribute of the man file, so I didn't changed it.
Please fix exec bits on man page, no reason not to fix that. desktop file has Icon=style , however no style image is shipped.
OK, both issues fixed. Please find updated files here: Spec URL: http://sites.google.com/site/gracca/gtk-chtheme.spec SRPM URL: http://sites.google.com/site/gracca/gtk-chtheme-0.3.1-4.fc13.src.rpm Cheers, German.
*** Bug 541724 has been marked as a duplicate of this bug. ***
Files moved to fedorapeople.org: Spec URL: http://skytux.fedorapeople.org/packages/gtk-chtheme.spec SRPM URL: http://skytux.fedorapeople.org/packages/gtk-chtheme-0.3.1-4.fc13.src.rpm
ok rpmlint ok named and versioned according to the Package Naming Guidelines ok spec file name matches base package name ok license : GPLv2+ tag correct and all files with license info ok COPYING packaged as %doc ok source matches upstream: dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2 dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2.1 ! builds in koji: something is wrong here, might be missing #include, please have a look. Ref: http://koji.fedoraproject.org/koji/taskinfo?taskID=2310790 http://koji.fedoraproject.org/koji/getfile?taskID=2310792&name=build.log ok no missing BuildRequires (builds in mock) ok no translations, so translation/locale guidelines don't apply ok no shared libraries, so no ldconfig calls neeed ok no duplicated system libraries ok package not relocatable ok directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories) ok no duplicate files in %files ! permissions correct, defattr used correctly please drop %attr on man page, change to correct mode in %install. %attr is for special cases. ok macros ok no non-code content ok no large documentation files, so no -doc package needed ok no %doc files required at runtime ok no header files which would need to be in a -devel subpackage ok no static libraries, so no -static package needed ok no devel symlinks which would need to be in a -devel subpackage ok no -devel package, ok no .la files ok .desktop file ok desktop-file-validate is used in %install and the .desktop file passes validation ok all filenames are valid UTF-8 ok complies with the FHS ok proper changelog, tags, BuildRoot, BuildRequires, Summary, Description ok no macros in Summary and Description ok no non-UTF-8 characters ok all relevant documentation included as %doc ok RPM_OPT_FLAGS are used (%cmake macro) ok debuginfo package is valid ok no rpaths ok no configuration files, so %config guideline doesn't apply ok no init scripts, so init script guideline doesn't apply ok no timestamp-clobbering file commands ok _smp_mflags used ok not a web application, so web application guideline doesn't apply ok no conflicts Please have a look on items marked with ! .
Hello Terje: Thanks for the full review! But I can't find what is the problem in the build for F-14. For F-12 and F-13 it builds fine. With respect to the man page, no problem, I'll correct it, but please can you give me some hints about the build error? Regards, German.
Seems like a change in GTK is the problem, I added a patch and it built fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2318320 spec: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme.spec srpm: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme-0.3.1-5.fc12.src.rpm Note: only built, not tested.
Forgot: patch might work on all active Fedora releases, no special cace for F-14 needed.
(In reply to comment #7) > Seems like a change in GTK is the problem, I added a patch and it built fine: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=2318320 > > spec: http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme.spec > srpm: > http://terjeros.fedorapeople.org/gtk-chtheme/gtk-chtheme-0.3.1-5.fc12.src.rpm > > Note: only built, not tested. Hello Terje: Many thanks for your help with the patch! I also have corrected the permission of the man page in the right way. I've tested it under FC13 and works fine. Koji builds from scratch: dist-f12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322311 dist-f13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322367 dist-rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2322382 $ rpmlint rpmbuild/{SPECS,SRPMS,RPMS/i686}/gtk-chtheme* gtk-chtheme.i686: W: unstripped-binary-or-object /usr/bin/gtk-chtheme 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Please find the updated files here: Spec: http://skytux.fedorapeople.org/packages/gtk-chtheme.spec SRPM: http://skytux.fedorapeople.org/packages/gtk-chtheme-0.3.1-6.fc13.src.rpm Regards, German.
Thanks, all is good. The package gtk-chtheme is APPROVED.
(In reply to comment #10) > Thanks, all is good. > > The package gtk-chtheme is APPROVED. Thank you very much for the review Terje!
New Package CVS Request ======================= Package Name: gtk-chtheme Short Description: Gtk+ 2.0 theme preview and selection made slick Owners: skytux Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
gtk-chtheme-0.3.1-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-6.fc12
gtk-chtheme-0.3.1-6.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-6.fc13
gtk-chtheme-0.3.1-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
gtk-chtheme-0.3.1-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: gtk-chtheme New Branches: el6 Owners: splinux skytux I'm authorizing the user splinux to co-maintain this epel branch for gtk-chtheme.
Git done (by process-git-requests).
gtk-chtheme-0.3.1-11.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gtk-chtheme-0.3.1-11.el6
gtk-chtheme-0.3.1-11.el6 has been pushed to the Fedora EPEL 6 stable repository.