Description of problem: gfs2_edit restoremeta <metadata> <device> returns 0 even if the metadata could not be fully written to the destination device. Version-Release number of selected component (if applicable): gfs2-utils-0.1.62-20.el5 How reproducible: gfs2_edit restoremeta datavol03.meta /dev/vedder/vedder0 ; echo $? There are 53311488 blocks of 4096 bytes in the destination file system. 440846 metadata blocks (1722MB) restored. Error: File system is too small to restore this metadata. File system is 53311488 blocks, Restore block = 53345526 File datavol03.meta-bz519049 restore error. 0 Actual results: exit code == 0 Expected results: exit code != 0 if error has occured Additional info:
This should be easy to fix; requesting ack flags for inclusion into 5.6.
Created attachment 426372 [details] Patch to fix the problem Here is the patch to fix the problem. I tested it on roth-01.
I pushed the patch to the RHEL56 branch of the cluster git tree for inclusion into RHEL 5.6. The upstream equivalent has already been pushed by way of another bugzilla record. This was tested on roth-01. Changing status to POST until we build it.
Build 2768496 successful. Changing status to Modified. This fix is in gfs2-utils-0.1.62-25.el5.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0135.html