RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

+++ This bug was initially created as a clone of Bug #607229 +++

Description of problem:
gfs2_edit restoremeta <metadata> <device> returns 0 even if the metadata could not be fully written to the destination device.

Version-Release number of selected component (if applicable):
gfs2-utils-0.1.62-20.el5

How reproducible:

gfs2_edit restoremeta datavol03.meta /dev/vedder/vedder0 ; echo $?
There are 53311488 blocks of 4096 bytes in the destination file system.

440846 metadata blocks (1722MB) restored.    Error: File system is too small to restore this metadata.
File system is 53311488 blocks, Restore block = 53345526
File datavol03.meta-bz519049 restore error.
0

  
Actual results:
exit code == 0

Expected results:
exit code != 0 if error has occured

Additional info:

--- Additional comment from rpeterso on 2010-06-23 10:59:28 EDT ---

This should be easy to fix; requesting ack flags for inclusion
into 5.6.

--- Additional comment from rpeterso on 2010-06-23 15:43:03 EDT ---

Created an attachment (id=426372)
Patch to fix the problem

Here is the patch to fix the problem.  I tested it on roth-01.

I pushed the fix to the master branch of the gfs2-utils git
tree, and the STABLE3 and RHEL6 branches of the cluster git
tree for inclusion into RHEL6.0.  Changing status to POST
until we get it built.

http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=6571b0c8747f33ec244917bad1720ddab967c185

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.