Spec URL: http://till.fedorapeople.org/review/mspdebug.spec SRPM URL: http://till.fedorapeople.org/review/mspdebug-0.9-2.0.20100702git74a11c1a.fc12.src.rpm Description: A a free debugger for use with MSP430 MCUs. It supports FET430UIF, eZ430, RF2500 and TI Chronos devices. It can be used as a proxy for gdb or as an independent debugger with support for programming, disassembly and reverse engineering.
rpmlint only complains about not knowing gdb. I just noticed the typo in the first sentence of the description, I will fix it if other issues come up or before building it in Fedora if it is ok for the reviewer.
Hi Till, Why are you shipping the git version, rather than the release? Cheers, Rob
(In reply to comment #2) > Why are you shipping the git version, rather than the release? The git repo contains all the patches I need to use it with a MSP-Fet430UIF to debug TelosB motes.
We should include the udev rule to enable the UIF and EZ430 to act as a serial device: SUBSYSTEM=="usb", ACTION=="add", ATTR{product}=="MSP-FET430UIF JTAG Tool", \ ATTR{bNumConfigurations}=="2", ATTR{bConfigurationValue}="2" Cheers, Rob
(In reply to comment #4) > SUBSYSTEM=="usb", ACTION=="add", ATTR{product}=="MSP-FET430UIF JTAG Tool", \ > ATTR{bNumConfigurations}=="2", ATTR{bConfigurationValue}="2" This seems not to be needed for the Fedora kernel. I believe I read somewhere that it was only required for older kernels.
Yes, it appears you're completely correct. I've just tried a FET430 without the udev rule and it worked fine :)
I've just realised I can review this... took a while for that to sink it, sorry!
Here's my review :) (Took me a while for it to sink in that I could review it!) % rpmlint mspdebug.spec mspdebug.spec: W: invalid-url Source0: mspdebug-0.9git74a11c1a.tar.bz2 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Will be fixed by bumping up to 0.10, as this should contain those patches that you wanted. Everything else looks good to me. So I'll accept and then we can do the bump after import. (ACCEPT :)
Thank you for the review, I'll bump it to 0.10 before import. New Package SCM Request ======================= Package Name: mspdebug Short Description: Debugger and gdb proxy for MSP430 MCUs Owners: till rspanton Branches: f12 f13 f14 InitialCC:
Git done (by process-git-requests).
mspdebug-0.10-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/mspdebug-0.10-1.fc13
mspdebug-0.10-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/mspdebug-0.10-1.fc14
mspdebug-0.10-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mspdebug-0.10-1.fc12
mspdebug-0.10-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mspdebug'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/mspdebug-0.10-1.fc14
mspdebug-0.10-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mspdebug-0.10-2.fc12
mspdebug-0.10-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/mspdebug-0.10-2.fc13
mspdebug-0.10-2.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/mspdebug-0.10-2.fc14
mspdebug-0.10-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mspdebug-0.10-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
mspdebug-0.10-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.