Spec URL: http://people.freedesktop.org/~whot/mtdev.spec SRPM URL: http://people.freedesktop.org/~whot/mtdev-1.0.1-2.20100706.fc14.src.rpm Description: mtdev is a stand-alone library which transforms all variants of kernel MT events to the slotted type B protocol. The events put into mtdev may be from any MT device, specifically type A without contact tracking, type A with contact tracking, or type B with contact tracking.
Review: - license ok - Why do you BR git? Because you use it to make the sources? - name: How about "libmtdev" like e.g. libacpi or libmpd? - %doc: Please add README and CREDITS - Please use: 'make install DESTDIR=%{buildroot} INSTALL="install -p"' - You mix $RPM_BUILD_ROOT and %{buildroot} - libfoo.so needs to be in the -devel package: from rpmlint: mtdev.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmtdev.so - mtdev.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmtdev.so.1.0.0 mtdev.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmtdev.so.1.0.0 see: https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries - mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol translation library development package.
(In reply to comment #1) > Review: > - name: How about "libmtdev" like e.g. libacpi or libmpd? It seems like this package don't need lib in package name. From naming guideline: When naming a package, the name should match the upstream tarball or project name from which this software came.
(In reply to comment #2) > (In reply to comment #1) > > Review: > > - name: How about "libmtdev" like e.g. libacpi or libmpd? > It seems like this package don't need lib in package name. > > From naming guideline: > When naming a package, the name should match the upstream tarball or project > name from which this software came. ok, scratch that from the list. I just found it reasonable to name it like that, so this is just a matter of upstream naming...
(In reply to comment #1) > Review: > - Why do you BR git? Because you use it to make the sources? sorry, you're right, that's not needed. > - name: How about "libmtdev" like e.g. libacpi or libmpd? I was tempted, but as you said - upstream naming is mtdev so I decided to stick with it. > - %doc: Please add README and CREDITS > - Please use: 'make install DESTDIR=%{buildroot} INSTALL="install -p"' > - You mix $RPM_BUILD_ROOT and %{buildroot} all three fixed. > - libfoo.so needs to be in the -devel package: > from rpmlint: mtdev.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/libmtdev.so moved > - mtdev.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmtdev.so.1.0.0 > mtdev.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmtdev.so.1.0.0 > see: https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > > - mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol > translation library development package. your rpmlint is more picky than mine it seems :) I didn't get any of these, I wonder what I'm doing wrong here. I also bumped the release down to 1, damn copy/paste... Updated files are available on: http://people.freedesktop.org/~whot/mtdev-1.0.1-1.20100706.fc14.src.rpm http://people.freedesktop.org/~whot/mtdev.spec
(In reply to comment #4) > (In reply to comment #1) > your rpmlint is more picky than mine it seems :) I didn't get any of these, I > wonder what I'm doing wrong here. Hmm, in rawhide is the same rpmlint than in F-13 (from the numbering, it's just a bit bigger, whyever....) Remaining rpmlint output: $ rpmlint ./mtdev-1.0.1-1.20100706.fc13.src.rpm x86_64/mtdev* mtdev.src: W: spelling-error Summary(en_US) Multitouch -> Multitudinous, Multitude, Multitask mtdev.src: W: strange-permission make-git-snapshot.sh 0755L mtdev.src: W: invalid-url Source0: mtdev-20100706.tar.bz2 mtdev.x86_64: W: spelling-error Summary(en_US) Multitouch -> Multitudinous, Multitude, Multitask mtdev-devel.x86_64: W: spelling-error Summary(en_US) multitouch -> multitudinous, multitude, multitask mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol translation library development package. mtdev-devel.x86_64: W: summary-ended-with-dot C multitouch protocol translation library development package. mtdev-devel.x86_64: W: spelling-error %description -l en_US Multitouch -> Multitudinous, Multitude, Multitask mtdev-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 9 warnings. So the summary-not-capitalized is still in the -devel package, the rest is ignorable. > I also bumped the release down to 1, damn > copy/paste... Updated files are available on: > > http://people.freedesktop.org/~whot/mtdev-1.0.1-1.20100706.fc14.src.rpm > http://people.freedesktop.org/~whot/mtdev.spec You should bump the release, when doing changes to the spec like you would do in CVS later on, but now it's approved (just capitalize the summary, when importing). ____________________________________________________________________________ APPROVED
New Package CVS Request ======================= Package Name: mtdev Short Description: Multitouch Protocol Translation Library Owners: whot Branches: InitialCC:
CVS done (by process-cvs-requests.py).
Hi, Will this new package is likely to fix bugs like bug #583512 or bug #613220 or is it completely unrelated?
unrelated, this is the base package for future true multitouch support that's currently being worked on upstream. package is imported, closing as NEXTRELEASE