SPEC: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM.spec SRPM: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM-0.5.0-1.el6.src.rpm Description: PAM (Pluggable Authentication Module) bindings for Python. rpmlint /home/msuchy/rpmbuild/SRPMS/PyPAM-0.5.0-1.el6.src.rpm PyPAM.src: W: spelling-error %description -l en_US Pluggable -> Plug gable, Plug-gable, Plugged $ rpmlint /home/msuchy/rpmbuild/RPMS/x86_64/PyPAM-0.5.0-1.el6.x86_64.rpm PyPAM.x86_64: W: spelling-error %description -l en_US Pluggable -> Plug gable, Plug-gable, Plugged are IMHO false negatives Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2308975
I'll take the review
NEEDSWORK: rpmlint must be run on every package. The output should be posted in the review. PyPAM.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/PAMmodule.so PAMmodule.so()(64bit) 3 packages and 0 specfiles checked; 0 errors, 1 warnings. You will need to filter provides: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_provides_.28pre-scan_filtering.29 OK: The package must be named according to the Package Naming Guidelines. OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. . NEEDSWORK: The package must meet the Packaging Guidelines . * use %{__python} in %build section * do not use INSTALLED_FILES, it is explicitly discouraged in Python packaging guidelines (remember to use python_sitearch for *so module) See https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling * source tarball contains rpms and other binary files in dist/ and build/ subdirs. Remove these directories in %prep OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: All independent sub-packages have License of their own (if it exists) OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. NEEDSWORK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. You put %{__python} in BRs. There is also BR on python-devel. Packaging guidelines recommend either python2-devel or python3-devel (both in case the package supports it). No need for explicit %{__python} BR. NA: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. NA: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK: Packages must NOT bundle copies of system libraries. NA: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. NA: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). NA: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. NA: Header files must be in a -devel package. NA: Static libraries must be in a -static package. NA: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. NA: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. NA: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Other: * Your package wouldn't work as is in F-12 and RHEL-5. If you don't plan to include this package there, no problem. Otherwsise: https://fedoraproject.org/wiki/Packaging:Python#Macros
All issues should be fixed. New SPEC: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM.spec new SRC.RPM: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM-0.5.0-4.el5_90sat.src.rpm
I had one bug in BR conditions: New SPEC: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM.spec new SRC.RPM: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM-0.5.0-6.el5_90sat.src.rpm
Actually I believe those BRs/Rs are not correct still. You have BR on python3-devel when on Fedora 13, but you don't re-define __python variable to point to python 3. See https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version This is however moot, because I checked and upstream doesn't support Python3 at all (I checked and it really doesn't work). Your spec file had BR on python3-devel but still used python2 to compile/install the package and because of that, it worked. So just have simple BR on python2-devel (no if-defs). I guess I should have been more clear about those BRs (python2 vs python3) when I started the official review. Sorry about that. Other than that package is OK now, so I'll approve once you fix those Python BRs
New SPEC: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM.spec new SRC.RPM: http://miroslav.suchy.cz/fedora/PyPAM/PyPAM-0.5.0-7.el5_90sat.src.rpm
Package is good now. APPROVED.
New Package CVS Request ======================= Package Name: PyPAM Short Description: PAM bindings for Python Owners: msuchy Branches: F-14, F-13, F-12, EL-5, EL-6, EL-4 InitialCC:
Git done (by process-git-requests).
PyPAM-0.5.0-7.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/PyPAM-0.5.0-7.fc13
PyPAM-0.5.0-7.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.