Bug 614416 - Review Request: python-scripttest - Helper to test command-line scripts
Summary: Review Request: python-scripttest - Helper to test command-line scripts
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Kopeček
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 604053
TreeView+ depends on / blocked
 
Reported: 2010-07-14 13:03 UTC by Martin Bacovsky
Modified: 2011-01-10 19:21 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-07-27 08:40:55 UTC
Type: ---
Embargoed:
dkopecek: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Martin Bacovsky 2010-07-14 13:03:38 UTC
Spec URL: http://mbacovsk.fedorapeople.org/python-scripttest/python-scripttest.spec
SRPM URL: http://mbacovsk.fedorapeople.org/python-scripttest/python-scripttest-1.0.4-1.fc13.src.rpm
Description: 
ScriptTest is a library to help you test your interactive 
command-line applications.

With it you can easily run the command (in a subprocess) and see 
the output (stdout, stderr) and any file modifications.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2318824

$ rpmlint python-scripttest-1.0.4-1.fc13.noarch.rpm
python-scripttest.noarch: W: spelling-error %description -l en_US subprocess -> sub process, sub-process, subprofessional
python-scripttest.noarch: W: spelling-error %description -l en_US stdout -> stout, std out, std-out
python-scripttest.noarch: W: spelling-error %description -l en_US stderr -> std err, std-err, stander
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint python-scripttest-1.0.4-1.fc13.src.rpm
python-scripttest.src: W: spelling-error %description -l en_US subprocess -> sub process, sub-process, subprofessional
python-scripttest.src: W: spelling-error %description -l en_US stdout -> stout, std out, std-out
python-scripttest.src: W: spelling-error %description -l en_US stderr -> std err, std-err, stander
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Comment 1 Daniel Kopeček 2010-07-21 09:32:07 UTC
I don't like how the documentation is packaged. The source files for the generated html docs aren't necessary for the reader. However, there's a link on each page to the corresponding source file so removing these files in %build breaks this "feature". Since this is a minor issue (and such source files are present in the wast majority of similar packages) and the package is conforming to the "MUST" rules, I think it can be accepted.

Comment 2 Martin Bacovsky 2010-07-21 09:41:12 UTC
I've moved the generated docs to html subdirectory. Content of _sources directory is linked from the html files so it has to stay there.
I've also added the license file into docs root.
Spec URL: 
http://mbacovsk.fedorapeople.org/python-scripttest/python-scripttest.spec
SRPM URL:
http://mbacovsk.fedorapeople.org/python-scripttest/python-scripttest-1.0.4-2.fc13.src.rpm

Comment 3 Martin Bacovsky 2010-07-21 11:37:02 UTC
New Package CVS Request
=======================
Package Name: python-scripttest
Short Description: Helper to test command-line scripts
Owners: mbacovsk
Branches: F-12 F-13
InitialCC:

Comment 4 Kevin Fenzi 2010-07-23 21:41:47 UTC
CVS done (by process-cvs-requests.py).

Comment 5 Martin Bacovsky 2010-07-27 08:40:55 UTC
Package was built in F-12, F-13 and devel branches. Aslo is ready to pass the rebuild with py2.7.

Comment 6 Martin Bacovsky 2011-01-10 15:15:21 UTC
Package Change Request
======================
Package Name: python-scripttest
New Branches: el6
Owners: mbacovsk

Comment 7 Jason Tibbitts 2011-01-10 19:21:34 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.