Bug 616507 - cpuspeed does not reset MIN/MAX values when config file is emptied
Summary: cpuspeed does not reset MIN/MAX values when config file is emptied
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cpuspeed
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 616524
TreeView+ depends on / blocked
 
Reported: 2010-07-20 16:32 UTC by François Cami
Modified: 2010-07-27 02:21 UTC (History)
1 user (show)

(edit)
Clone Of:
: 616524 616976 (view as bug list)
(edit)
Last Closed: 2010-07-27 02:21:20 UTC


Attachments (Terms of Use)
patch for /etc/init.d/cpuspeed (566 bytes, patch)
2010-07-20 16:32 UTC, François Cami
no flags Details | Diff

Description François Cami 2010-07-20 16:32:50 UTC
Created attachment 433207 [details]
patch for /etc/init.d/cpuspeed

Description of problem:
When MIN_SPEED (resp. MAX_SPEED) is set in /etc/sysconfig/cpuspeed, and then removed, /etc/init.d/cpuspeed does not reset the value to the CPU minimum (resp. maximum) frequency.

Version-Release number of selected component (if applicable):
cpuspeed-1.5-13.fc13.x86_64

How reproducible:
Always

Steps to Reproduce:
0. check CPU frequency using cat /proc/cpuinfo
1. Set MIN_SPEED in /etc/sysconfig/cpuspeed to a suitable value superior to the CPU's minimum frequency
2. restart cpuspeed
3. Unset MIN_SPEED (restore configuration file)
4. restart cpuspeed
5. check CPU frequency using cat /proc/cpuinfo
  
Actual results:
CPU frequency in step 5 is equal to the MIN_SPEED set at step 1.

Expected results:
CPU frequency in steps 0 and 5 are identical.

Additional info:
This is because the cpuspeed script does not reset the values when the {MIN_SPEED,MAX_SPEED} variables are empty. A (crude) patch to do that is attached.

Comment 1 Fedora Update System 2010-07-21 12:11:29 UTC
cpuspeed-1.5-14.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/cpuspeed-1.5-14.fc13

Comment 2 Petr Šabata 2010-07-21 12:18:13 UTC
Thank you for the patch.
This should now be fixed in 1:1.5-14 in both Fedora 13 and Rawhide.

Comment 3 François Cami 2010-07-21 19:57:49 UTC
Petr,

You are welcome.

The koji build:
http://koji.fedoraproject.org/koji/buildinfo?buildID=184831
fixes the bug on my Athlon X2.

I suppose bodhi will close this bug once the package is pushed to updates.

Comment 4 Petr Šabata 2010-07-22 08:35:15 UTC
(In reply to comment #3)
> Petr,
> 
> You are welcome.
> 
> The koji build:
> http://koji.fedoraproject.org/koji/buildinfo?buildID=184831
> fixes the bug on my Athlon X2.
> 
> I suppose bodhi will close this bug once the package is pushed to updates.    

Yes, it does so once the maximum positive karma (three in this case) is reached or certain amount of time passes.

Comment 5 Fedora Update System 2010-07-23 02:24:25 UTC
cpuspeed-1.5-14.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cpuspeed'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cpuspeed-1.5-14.fc13

Comment 6 Fedora Update System 2010-07-27 02:21:16 UTC
cpuspeed-1.5-14.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.