Description of problem: noarch packages built by plague no longer work after installing mock with "added logic to detect invalid architecture combinations (BZ# 607144)" patch applied. Version-Release number of selected component (if applicable): 1.0.9 How reproducible: always Steps to Reproduce: 1. try to build a noarch package using updated mock Actual results: Mock returns: "ERROR: Cannot build target noarch on arch x86_64" Expected results: Package builds as it used to prior to upgrading mock Additional info:
Shad, Got an SRPM that I can use to test with? I'd prefer to use one that you tried and had fail...
Hi, Clark! A patch along these lines fixes it for me, although youmay want to add noarch to more legal_arches, or maybe test it separately, accepting it regardless of legal_arches. --- /usr/sbin/mock.broken-noarch 2010-08-03 17:04:48.000000000 -0400 +++ /usr/sbin/mock 2010-08-13 13:37:00.000000000 -0400 @@ -370,8 +370,8 @@ legal_arches = { 'i386' : ('i386', 'i686'), - 'i686' : ('i386', 'i686'), - 'x86_64' : ('i386', 'i686', 'x86_64'), + 'i686' : ('i386', 'i686', 'noarch'), + 'x86_64' : ('i386', 'i686', 'x86_64', 'noarch'), 'ppc' : ('ppc'), 'ppc64' : ('ppc', 'ppc64'), 'sparc' : ('sparc'),
Hi Alex! I got a patch from Paul Howarth that fixes is for all arches: diff --git a/py/mock.py b/py/mock.py index f585002..975ef42 100755 --- a/py/mock.py +++ b/py/mock.py @@ -383,7 +383,7 @@ decorate(traceLog()) def check_arch_combination(target_arch): host_arch = os.uname()[-1] try: - if target_arch not in legal_arches[host_arch]: + if target_arch not in legal_arches[host_arch] + ('noarch',): raise mock.exception.InvalidArchitecture( "Cannot build target %s on arch %s" % (target_arch, host_arch)) except KeyError: I'm working on a 1.1.4 release that will have this and a few other fixes in it.
mock-1.1.4-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/mock-1.1.4-1.fc14
mock-1.1.4-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/mock-1.1.4-1.fc13
mock-1.0.11-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mock-1.0.11-1.fc12
mock-1.0.11-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/mock-1.0.11-1.el5
mock-1.0.11-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mock'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/mock-1.0.11-1.el5
mock-1.1.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.0.11-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.0.12-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/mock-1.0.12-1.fc12
mock-1.0.12-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.12-1.el5
mock-1.0.13-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.13-1.el5
mock-1.0.13-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/mock-1.0.13-1.fc12
mock-1.0.14-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.14-1.el5
mock-1.0.15-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.15-1.el5
mock-1.1.9-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.9-1.fc13
mock-1.0.16-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.16-1.el5
mock-1.1.9-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.9-1.el6
mock-1.1.9-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.9-1.fc14
mock-1.1.9-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.9-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.10-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc15
mock-1.1.10-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc14
mock-1.0.17-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mock-1.0.17-1.el5
mock-1.1.10-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/mock-1.1.10-1.fc13
mock-1.1.10-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mock-1.1.10-1.el6
mock-1.1.10-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.10-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.0.17-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
mock-1.1.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.