Bug 626462 - Review Request: libmstun - A C++ library providing STUN client utilities
Review Request: libmstun - A C++ library providing STUN client utilities
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kalev Lember
Fedora Extras Quality Assurance
Depends On: 626446 626458
  Show dependency treegraph
Reported: 2010-08-23 11:43 EDT by Peter Lemenkov
Modified: 2010-11-04 19:42 EDT (History)
4 users (show)

See Also:
Fixed In Version: libmstun-0.8.0-0.1.20091007svn3734.fc14
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-10-13 12:28:49 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kalevlember: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Peter Lemenkov 2010-08-23 11:43:05 EDT
Spec URL: http://peter.fedorapeople.org/libmstun.spec
SRPM URL: http://peter.fedorapeople.org/libmstun-0.8.0-0.1.20091007svn3734.fc12.src.rpm
Description: libmstun provides support for implementing STUN in client applications.
It is used by the minisip project.

No koji build for now since it depends on a libraries not yet added to Fedora.

It's another one requirement for minisip.
Comment 1 Kalev Lember 2010-10-11 08:10:08 EDT
Taking for review and removing the Whiteboard: NotReady as all deps are now in rawhide.
Comment 2 Kalev Lember 2010-10-11 08:11:28 EDT
Scratch build:
Comment 3 Kalev Lember 2010-10-11 08:28:25 EDT
Fedora review libmstun-0.8.0-0.1.20091007svn3734.fc12.src.rpm 2010-10-11

+ OK
! needs attention

rpmlint output:
$ rpmlint libmstun \
          libmstun-devel \
          libmstun-0.8.0-0.1.20091007svn3734.fc15.src.rpm \
libmstun.i686: W: spelling-error %description -l en_US minisip -> mini sip, mini-sip, minister
libmstun.i686: W: unused-direct-shlib-dependency /usr/lib/libmstun.so.0.0.0 /lib/libm.so.6
libmstun.i686: W: shared-lib-calls-exit /usr/lib/libmstun.so.0.0.0 exit@GLIBC_2.0
libmstun-devel.i686: W: spelling-error Summary(en_US) libmnstun -> libertinism, libidinous, libertine
libmstun-devel.i686: W: no-documentation
libmstun.src: W: spelling-error %description -l en_US minisip -> mini sip, mini-sip, minister
libmstun.src: W: invalid-url Source0: libmstun-0.8.0.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 7 warnings.

+ Rpmlint warnings are mostly harmless and can be ignored.
  shared-lib-calls-exit is something to talk about with upstream as it might
  result in application crashes if a library unexpectedly calls exit().
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
  from upstream svn repo produce matching tarball.
  8bcc8a0dddc84d3a7e87484c3dda5974  libmstun-0.8.0.tar.bz2

+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

Looks good.

Comment 4 Peter Lemenkov 2010-10-11 08:40:41 EDT
New Package SCM Request
Package Name: libmstun
Short Description: A C++ library providing STUN client utilities
Owners: peter
Branches: f12 f13 f14 el6
Comment 5 Kevin Fenzi 2010-10-11 14:26:02 EDT
Git done (by process-git-requests).
Comment 6 Kalev Lember 2010-10-13 12:28:49 EDT
libmstun is imported and built for rawhide. Closing the ticket to make it easier to check bugzilla dependencies between review requests.
Comment 7 Fedora Update System 2010-10-21 02:17:03 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc13 has been submitted as an update for Fedora 13.
Comment 8 Fedora Update System 2010-10-21 02:17:11 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc12 has been submitted as an update for Fedora 12.
Comment 9 Fedora Update System 2010-10-21 02:17:18 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc14 has been submitted as an update for Fedora 14.
Comment 10 Fedora Update System 2010-10-30 19:36:28 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2010-10-30 19:37:07 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2010-11-04 19:42:41 EDT
libmstun-0.8.0-0.1.20091007svn3734.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.