Bug 632051 - Review Request: libmeegotouch - MeeGo Touch Framework
Summary: Review Request: libmeegotouch - MeeGo Touch Framework
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 614297
TreeView+ depends on / blocked
 
Reported: 2010-09-09 03:07 UTC by Chen Lei
Modified: 2012-08-16 21:59 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-08-16 21:59:04 UTC
Type: ---
Embargoed:
jreznik: fedora-review?


Attachments (Terms of Use)
qmake in qtdir to qmake-qt4 (687 bytes, patch)
2010-10-04 13:13 UTC, Jaroslav Reznik
no flags Details | Diff
widgetsgallery demo dso - librt (366 bytes, patch)
2010-10-04 14:54 UTC, Jaroslav Reznik
no flags Details | Diff

Description Chen Lei 2010-09-09 03:07:47 UTC
Description:

Qt based MeeGo Touch Framework for developing touch based user interfaces.

Links:

http://dl.dropbox.com/u/1338197/1/libmeegotouch-0.20.25-1.fc13.src.rpm
http://dl.dropbox.com/u/1338197/1/libmeegotouch.spec

Comment 1 Jaroslav Reznik 2010-09-29 13:39:14 UTC
Name: ok
Summary: ok
Version & Release: ok
Group: ok
License: ok
URL: ok
Sources: caedf70a5851e2d1e1e9c282f40c841a ok
Patches: do we really need all patches? at least missing-Epoch-function is not needed anymore as we have Qt 4.7, please update
Requires & BuildRequires: XXXXXXXXXXXXXXX
Description: ok
Build: not ok

+ ./configure -prefix /usr -libdir /usr/lib64 -release

QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
If your Qt is in a nonstandard location, try:
QTDIR=<path to your Qt directory> ./configure
error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)


PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil. Thanks.

Comment 2 Chen Lei 2010-10-01 13:24:01 UTC
(In reply to comment #1)
> Patches: do we really need all patches? at least missing-Epoch-function is not
> needed anymore as we have Qt 4.7, please update

I removed patch5 from spec. All other patches are remained, they are all extracted from upstream SRPM, I think it'll be easier to track upstream RPM and bugzilla system closely. 

Currently, I track F14 with Meego 1.1 which will be released on 2010-10-27.

> Build: not ok
> 
> + ./configure -prefix /usr -libdir /usr/lib64 -release
> 
> QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
> If your Qt is in a nonstandard location, try:
> QTDIR=<path to your Qt directory> ./configure
> error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)
> 
It's weird, I can build the package in rawhide koji. Maybe this issue is trigger once the system has both qt3-devel and qt-devel installed.

> 
> PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt
> co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
> Thanks.

OK, please also apply co-maintainer for exsited meego packages in pkgdb(e.g. libaccounts-glib libaccounts-qt contextkit libqttracker).

Comment 4 Jaroslav Reznik 2010-10-04 12:55:16 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Patches: do we really need all patches? at least missing-Epoch-function is not
> > needed anymore as we have Qt 4.7, please update
> 
> I removed patch5 from spec. All other patches are remained, they are all
> extracted from upstream SRPM, I think it'll be easier to track upstream RPM and
> bugzilla system closely. 

Agreed.

> Currently, I track F14 with Meego 1.1 which will be released on 2010-10-27.

It's getting closer! 

> > Build: not ok
> > 
> > + ./configure -prefix /usr -libdir /usr/lib64 -release
> > 
> > QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
> > If your Qt is in a nonstandard location, try:
> > QTDIR=<path to your Qt directory> ./configure
> > error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)
> > 
> It's weird, I can build the package in rawhide koji. Maybe this issue is
> trigger once the system has both qt3-devel and qt-devel installed.

I'll check it - it should call qmake-qt4.

> > 
> > PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt
> > co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
> > Thanks.
> 
> OK, please also apply co-maintainer for exsited meego packages in pkgdb(e.g.
> libaccounts-glib libaccounts-qt contextkit libqttracker).

Great, applied.

Comment 5 Jaroslav Reznik 2010-10-04 13:13:05 UTC
Created attachment 451396 [details]
qmake in qtdir to qmake-qt4

I'm able to build it with this patch - it directly takes qmake-qt4 (not qmake - it's qt 3 one!).

Comment 6 Jaroslav Reznik 2010-10-04 14:54:00 UTC
Created attachment 451421 [details]
widgetsgallery demo dso - librt

This patch fixes librt DSO.

Still there's an issue with fdupes probably.

+ %fdupes /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
/var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
    Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)

Comment 7 Chen Lei 2010-10-05 06:56:58 UTC
(In reply to comment #5)
> Created attachment 451396 [details]
> qmake in qtdir to qmake-qt4
> 
> I'm able to build it with this patch - it directly takes qmake-qt4 (not qmake -
> it's qt 3 one!).

I don't think this patch is needed, my latest spec already export QTDIR before ./configure.


(In reply to comment #6)
> Created attachment 451421 [details]
> widgetsgallery demo dso - librt
> 
> This patch fixes librt DSO.
> 
> Still there's an issue with fdupes probably.
> 
> + %fdupes /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
> /var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
> RPM build errors:
> error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
>     Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)

You may use SRPM from meego upstream, %fudpes is a SUSE specific macro.


http://koji.fedoraproject.org/koji/taskinfo?taskID=2506423

Comment 8 Jaroslav Reznik 2010-10-05 07:44:36 UTC
> > Still there's an issue with fdupes probably.
> > 
> > + %fdupes /builddir/build/BUILDROOT/libmeegotouch-0.20.25-3.12.x86_64/usr/share
> > /var/tmp/rpm-tmp.nTKNCU: line 44: fg: no job control
> > RPM build errors:
> > error: Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
> >     Bad exit status from /var/tmp/rpm-tmp.nTKNCU (%install)
> 
> You may use SRPM from meego upstream, %fudpes is a SUSE specific macro.
> 
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2506423

Ah, sorry - you're right, by mistake I used upstream src.rpm :( (Downloaded in a same directory).

Comment 9 Jaroslav Reznik 2010-10-05 08:40:16 UTC
rpmlint libmeegotouch.spec 

libmeegotouch.spec:92: W: configure-without-libdir-spec
OK, libdir specified

libmeegotouch.spec: W: no-cleaning-of-buildroot %clean
libmeegotouch.spec: W: no-buildroot-tag
libmeegotouch.spec: W: no-%clean-section
OK, F14+ only

libmeegotouch.spec: W: invalid-url Source0: libmeegotouch-0.20.25.tar.bz2
OK, extracted from upstream src.rpm, commented

Comment 10 Jaroslav Reznik 2010-10-05 08:57:53 UTC
>rpmlint libmeegotouch-0.20.25-2.fc14.x86_64.rpm
 
libmeegotouch.x86_64: W: shared-lib-calls-exit /usr/lib64/libmeegotouchcore.so.0.20.24 exit.5
Not OK, please comment/fix.

libmeegotouch.x86_64: W: non-conffile-in-etc /etc/profile.d/libmeegotouch.sh
libmeegotouch.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/meegotouch.schemas
OK

libmeegotouch.x86_64: E: non-standard-dir-perm /var/cache/meegotouch 01777L
Not OK, is it really needed to pre-create cache dir with these permissions?

libmeegotouch.x86_64: W: no-manual-page-for-binary mthemedaemon
libmeegotouch.x86_64: W: no-manual-page-for-binary mservicemapper
OK
libmeegotouch.x86_64: W: dangerous-command-in-%pre rm
libmeegotouch.x86_64: W: dangerous-command-in-%post rm
OK, probably comes from %gconf_schema_upgrade (http://fedoraproject.org/wiki/Packaging/ScriptletSnippets)

>rpmlint libmeegotouch-qtstyle-0.20.25-2.fc14.x86_64.rpm 

libmeegotouch-qtstyle.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging
libmeegotouch-qtstyle.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging
OK

libmeegotouch-qtstyle.x86_64: W: no-documentation
OK, in main package

libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstylekinetic
libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstyledialogs
libmeegotouch-qtstyle.x86_64: W: no-manual-page-for-binary qtstyleexample
OK

> rpmlint libmeegotouch-devel-0.20.25-2.fc14.x86_64.rpm 
libmeegotouch-devel.x86_64: W: no-documentation
OK

libmeegotouch-devel.x86_64: W: spurious-executable-perm /usr/include/meegotouch/mrichtexteditstyle.h
Fix it, please.

libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mapplettester
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mapplicationextensiontester
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary dui-rename-files
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mgen
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mnotificationtool
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary widgetsgallery
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary dui-rename-symbols
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mmoc
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mmoc.pl
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary m-servicefwgen
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary mnotificationstresstest
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary animatedlayout
libmeegotouch-devel.x86_64: W: no-manual-page-for-binary applicationextensiondemo

OK

Summary - not OK (need comment/fix).

Comment 11 Chen Lei 2010-10-07 03:45:15 UTC
(In reply to comment #10)
> >rpmlint libmeegotouch-0.20.25-2.fc14.x86_64.rpm
> 
> libmeegotouch.x86_64: W: shared-lib-calls-exit
> /usr/lib64/libmeegotouchcore.so.0.20.24 exit.5
> Not OK, please comment/fix.
> 
This won't be a serious issue, I think it's safe to ignore this warning. Many core libraries use exit() function actually. 

> 
> libmeegotouch.x86_64: E: non-standard-dir-perm /var/cache/meegotouch 01777L
> Not OK, is it really needed to pre-create cache dir with these permissions?
> 
1777 is better than 777, this directory should be written by normal users.

> 
> Summary - not OK (need comment/fix).

How to fix?

Comment 12 Chen Lei 2010-10-19 16:06:20 UTC
I'll update libmeegotouch to 0.20.4x soon which is target for Meego 1.2. Since Meego haven't released Tablet UX yet, we still have a lot of time to package MTF stack packages.

Comment 13 Fedora End Of Life 2012-08-16 21:59:07 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.