SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-1.fc13.src.rpm Description: A simple Ruby library to parse robots.txt. Hello, Please could you review the package whatweb? Output from rpmlint: $ rpmlint rubygem-robots-0.10.0-1.fc13.src.rpm rubygem-robots-0.10.0-1.fc13.noarch.rpm #txt is in the reference to the name of the robots.txt file rubygem-robots.src: W: spelling-error Summary(en_US) txt -> text, ext, tit rubygem-robots.src: W: spelling-error %description -l en_US txt -> text, ext, tit rubygem-robots.noarch: W: spelling-error Summary(en_US) txt -> text, ext, tit rubygem-robots.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit #% is part urlencoded name of documentation file rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/ParsedRobots/allowed%3f-i.yaml %3f rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/timeout%3d-c.yaml %3d rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/allowed%3f-i.yaml %3f #% test scripts are commonly set with only 644 permission rubygem-robots.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/test/test_robots.rb 0644L /usr/bin/env Koji F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2462027
Some notes: * %define -> %global - Now we prefer to use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * BuildRoot - BuildRoot tag is no longer used on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * ruby(abi) Requires - Writing "R: ruby(abi) = 1.8" is a must https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * Requires - R: rubygem(shoulda) is not needed - thoughtbot-shoulda (not shoulda) dependency appeas in installed gemspec, however this is for development dependency and is not needed on runtime. * Duplicate %files entry ---------------------------------------------------------------- 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/CHANGELOG 59 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/README ---------------------------------------------------------------- - Please make it sure that all files are listed only once in %files entry. ! Note The %files entry ---------------------------------------------------------------- %files /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ itself and all files/directories/etc under /some_dir/ , while ---------------------------------------------------------------- %files %dir /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ only. * rpmlint issue ---------------------------------------------------------------- rubygem-robots.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/test/test_robots.rb 0644L /usr/bin/env ---------------------------------------------------------------- - This script need not have shebang and the shebang should be removed. * %check - As this gem contains test/ directory, please add %check section and execute some test program there ! Note To make "$ rake test" succeed, some modification against Rakefile is needed.
One more comment * Macros - Please use the defined %{geminstdir} macro consistently also in %files
ping?
Hello Mamoru, thank you for review, here is the updated package: SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-2.fc13.src.rpm I have tried to implement changes based on your comments. Unfortunately I was not able to implement all the changes you have been asking - mainly: * BuildRoot - having this tag is not an error - I would like to keep the package maintained for EPEL5 as well and I would prefer to have 1 spec if possible. * %check - some packages needed for test are not available in Fedora yet (shoulda, jeweler), I have included BuildRequire(check) dependencies and check section, but it is now commented out. I will uncomment as soon as the dependencies are available. Best regards Michal Ambroz
Sorry for late response. Well, * %check issue - rubygem(jeweler) is not strictly needed for $ rake test - also rubygem(shoulda) is only for gem.add_development_dependency and not needed for $ rake test - However Rakefile itself is broken for $ rake test. Please consider to apply the following patch and enable $ rake test on %check. ----------------------------------------------------------------- $ diff -u Rakefile.debug Rakefile --- Rakefile.debug 1970-01-01 09:00:00.000000000 +0900 +++ Rakefile 2010-09-13 02:32:52.000000000 +0900 @@ -21,7 +21,7 @@ require 'rake/testtask' Rake::TestTask.new(:test) do |test| test.libs << 'lib' << 'test' - test.pattern = 'test/**/*_test.rb' + test.pattern = 'test/**/test_*.rb' test.verbose = true end @@ -38,7 +38,7 @@ end end -task :test => :check_dependencies +#task :test => :check_dependencies task :default => :test ----------------------------------------------------------------- * Creating -doc subpackage - For rubygem based rpms, We usually suggest to create -doc subpackages, make -doc subpackage have "Requires: %{name} = %{version}-%{release}" and move the following files / directories to -doc subpackage. ---------------------------------------------------------------- %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/Rakefile %{geminstdir}/test ----------------------------------------------------------------
ping again?
Again ping?
Hello Mamoru, I am sorry - I forgot abuot the package. I will incorporate your suggestions.
Updated package: SPEC: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-3.fc14.src.rpm - added suggested patch - split doc package - enabled %check Best regards Michal Ambroz
Resigning in getting the anemone/robots to Fedora.