Red Hat Bugzilla – Bug 632919
Review Request: rubygem-anemone - Anemone web-spider framework
Last modified: 2012-04-16 22:11:49 EDT
SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-anemone.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-anemone-0.5.0-1.fc13.src.rpm Description: Anemone is a Ruby library that makes it quick and painless to write programs that spider a website. It provides a simple DSL for performing actions on every page of a site, skipping certain URLs, and calculating the shortest path to a given page on a site. The multi-threaded design makes Anemone fast. The API makes it simple. And the expressiveness of Ruby makes it powerful. Hello, Please could you review the package rubygem-anemone? It is needed for package whatweb. Output from rpmlint: $ rpmlint rubygem-anemone-0.5.0-1.fc13.src.rpm rubygem-anemone-0.5.0-1.fc13.noarch.rpm rubygem-anemone-doc-0.5.0-1.fc13.noarch.rpm rubygem-anemone.src: W: spelling-error %description -l en_US multi -> mulch, mufti rubygem-anemone.src: W: invalid-url Source0: http://gems.rubyforge.org/gems/anemone-0.5.0.gem <urlopen error timed out> rubygem-anemone.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti rubygem-anemone.noarch: W: no-manual-page-for-binary anemone #The rest are false-positive warings about unexpanded macros = urlencoded chars in filenames rubygem-anemone-doc.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/anemone-0.5.0/ri/Anemone/PageStore/shortest_paths%21-i.yaml %21 3 packages and 0 specfiles checked; 0 errors, 55 warnings. Koji F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2462142
For some general issues, please also check my commentes on bug 632912. ! Note Usually when gem contains spec/ directory, $ rake spec should be executed in %check.
Hello Mamoru, here updated packages: SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-anemone.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-anemone-0.5.0-2.fc13.src.rpm *BuildRoot I would like to keep BuildRoot for compatibility with EPEL5. *%check Checks require couple of another rubygems packackages, which are not yet in Fedoram so I had to comment out this functionality for now. Best regards Michal Ambroz
Almost okay. * Explicit version specific dependency - We usually don't write explicit version specific dependency (like ">= 1.3.0" part on "Requires: rubygem(nokogiri)" when all packages on currently supported Fedora (or EPEL) branches statisfied such dependency because it is just redundant: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * %doc in -doc subpackage - %doc attribute in -doc subpackage is redundant because the name of the rpm already indicates that the files in the rpm is for documentation.
Updated package: SPEC: http://rebus.fedorapeople.org/SPECS/rubygem-anemone.spec SRPM: http://rebus.fedorapeople.org/SRPMS/rubygem-anemone-0.5.0-3.fc14.src.rpm - fixed doc package and explicit dependency as suggested Best regards Michal Ambroz
Resigning in getting the anemone to Fedora.