Hi,

some comments to start:

1) be careful with the release: since the sources are taken from a VCS, the Release tag should look like:
   Release:   0.1.20100821bzr
("1" corresponds to the "release number increment", "20100821" to the date of the last commit in the bazaar repo and "bzr" to the VCS used by upstream).

See for more details:
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#PreReleasePackages

2) In Summary, the dash in "GNOME-desktop" is useless maybe

3) I don't think gstreamer-java is really required

4) In %description, maybe you should remove the reference to MP3 in the list of supported formats... 
    Dont forget also a dot at the end of the description

5) DON'T use CFLAGS to set additional linker flags. You'd better use LDFLAGS:
   export LDFLAGS=" -lm"
   %configure
   make %{?_smp_mflags}

Thanks a lot for yours comments.

You can find now package updated here :

SPEC URL : http://cedric.olivier.free.fr/rpms/rec-applet-0.2.20100821/rec-applet.spec
SRPMS URL : http://cedric.olivier.free.fr/rpms/rec-applet-0.2.20100821/rec-applet-0-0.2.20100821bzr.fc13.src.rpm

I had forgotten to add gtk-update-icon-cache :

Spec URL : http://cedric.olivier.free.fr/rpms/rec-applet-0.3.20100821/rec-applet.spec
SRPMS URL : http://cedric.olivier.free.fr/rpms/rec-applet-0.3.20100821/rec-applet-0-0.3.20100821bzr.fc13.src.rpm

ping

You can remove the following useless BuildRequires:
- glib2-devel (already required by gtk2-devel)
- gtk2-devel (already required by gnome-media-devel)
- gstreamer-devel (already required by gstreamer-plugins-base-devel)
But you must add the following Requires:
- hicolor-icon-theme (to own %{_datadir}/icons/hicolor/48x48/apps/)
- libbonobo (to own %{_libdir}/bonobo/servers/).

Be careful by the way to unowned directories: neither %{_datadir}/%{name}/ nor %{_datadir}/pixmaps/%{name}/ are owned by your package. Please correct your %files section as following:
   %files -f %{name}.lang
   %defattr(-,root,root,-)
   %{_bindir}/%{name}
   %{_datadir}/%{name}/
   %{_datadir}/pixmaps/%{name}/
   %{_datadir}/icons/hicolor/48x48/apps/%{name}.png
   %{_libdir}/bonobo/servers/%{name}.server

Please remove all the references to josm in the rec-applet-generate-tarball.sh script. Moreover, you should be able to choose the revision you want to download using the script (with a given parameter corresponding to revision), and mention it in the name of the generated source archive; otherwise the script is in fact useless and you'd better indicate in the comments how th grab the archive source: for example (here updated to the latest snapshot):
   %global bzr_revision 24
   %global bzr_version 20101011

   Name:           rec-applet
   Version:        0
   Release:        0.3.%{bzr_version}bzr%{?dist}
   [...]
   # The source for this package was pulled from upstream's vcs.  Use the
   # following commands to generate the tarball:
   #  bzr export -r %{bzr_revision} rec-applet-%{bzr_version}bzr.tar.bz2 lp:rec-applet
   Source0: %{name}-%{bzr_version}bzr.tar.bz2
Note that using the given bzr command in the comments, you'll get automatically a .tar.bz2 source archive, which should be better compressed than a .tar.gz one. You can take example on this comment to write a _real_ script to grab the sources.

I forgot this: you should update your package to the latest bzr snapshot, a lot of new translations are available, as well as some minor bug fixes.

Thanks a lot for this review.
After an upstream request, there is now a branch for 0.2.3 rec-applet release.

So you can find here an updated package with the last release and modifications according your lasts comments.

Spec file : http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-1/rec-applet.spec
SRPM file: http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-1/rec-applet-0.2.3-1.fc13.src.rpm

This last version looks OK for me. I've just tested this applet and it works very fine. Just one issue, not relative to your packaging: when I want to display the help from the settings panel, I get the following error:
   "Cannot start the internet browser. Please open the help file <doc. to open> manually."
After checking the code, it seems the applet tries to call sensible-browser to open the help, a Debian-centric script to launch the default browser.

I suggest you to:
- replace this call to xdg-open, the best solution to launch a browser according to user's environment settings, in a *portable* way. No patch is needed for this, sed is enough : in %prep, add this:
   sed -i "s|/usr/bin/sensible-browser|%{_bindir}/xdg-open|" src/help.c
- add a Requires on xdg-utils
- try to direct the upstream's attention to xdg utilities.

Once this thing done, I'll approve this great package.

By the way, report also the linking issue you tried to correct by setting manually LDFLAGS to "-lm".

Thanks.

So you can find here an updated package with the last release and modifications
according your last comment.

Spec file :
http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-2/rec-applet.spec
SRPM file:
http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-2/rec-applet-0.2.3-2.fc13.src.rpm

Sorry for the late answer. As promised, the approval of your package:

MUST: rpmlint must be run on every package.
->OK, only spelling issue without importance

MUST: The package must be named according to the Package Naming Guidelines.
->OK

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
->OK

MUST: The package must meet the Packaging Guidelines.
->OK

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
->OK

MUST: The License field in the package spec file must match the actual license.
->OK, all files under GPL v3

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
->/!\ NOK /!\

MUST: The spec file must be written in American English.
->OK

MUST: The spec file for the package MUST be legible.
->OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
-> OK, md5sum = b64eea40b5593b7f8dab87e1bc24e5fd

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
->OK, see http://koji.fedoraproject.org/koji/taskinfo?taskID=2588619

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
->N/A

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
->OK

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
->OK

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
->N/A

MUST: Packages must NOT bundle copies of system libraries.
->N/A

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
->N/A

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
->OK

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. 
->OK

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
->OK

MUST: Each package must consistently use macros.
->OK

MUST: The package must contain code, or permissable content.
->OK

MUST: Large documentation files must go in a -doc subpackage.
->N/A

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
->N/A

MUST: Header files must be in a -devel package.
->N/A

MUST: Static libraries must be in a -static package.
->N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
->N/A

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
->N/A

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
->OK

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
->N/A

MUST: Packages must not own files or directories already owned by other
packages.
->OK

MUST: All filenames in rpm packages must be valid UTF-8.
->OK


You MUST include the COPYING file in sources as %doc. You have to put as well the ChangeLog, README, NEWS, TODO and AUTHORS files as %doc.
Note that COPYING is nevertheless installed in /usr/share/rec-applet/. Not a good place to store licenses files... Try to remove it.

By the way, not mandatory, but you can use %{name} instead of « rec-applet » in the URL.

Thanks.

So you can find here an updated package with the last release and modifications
according your last comment.

Spec file :
http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-3/rec-applet.spec
SRPM file:
http://cedric.olivier.free.fr/rpms/rec-applet-0.2.3-3/rec-applet-0.2.3-3.fc13.src.rpm

Looks OK now :)

This package is APPROVED.

New Package SCM Request
=======================
Package Name: rec-applet
Short Description: An audio recording applet
Owners: cquad
Branches: F-13 F-14
InitialCC: cquad

Git done (by process-git-requests).

rec-applet-0.2.3-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rec-applet-0.2.3-3.fc13

rec-applet-0.2.3-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rec-applet-0.2.3-3.fc14

rec-applet-0.2.3-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rec-applet'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rec-applet-0.2.3-3.fc13

rec-applet-0.2.3-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rec-applet-0.2.3-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.