SPEC: http://pbrobinson.fedorapeople.org/meego-panel-pasteboard.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-pasteboard-0.0.8-1.fc14.src.rpm Description: MeeGo Panel for Paste Board Original review: https://bugzilla.redhat.com/show_bug.cgi?id=518448
Two things to fix: - license should probably be GPLv2+ - nobody owns the panels directory. mutter-meego should probably do this * TODO Review [80%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream ** TODO License [2/3] *** DONE License is Fedora-approved *** FAIL License field accurate License is GPLv2+ *not* LGPLv2+ *** DONE License included iff packaged by upstream ** DONE rpmlint [2/2] *** DONE on src.rpm meego-panel-pasteboard.src:3: W: macro-in-comment %{version} meego-panel-pasteboard.src:3: W: macro-in-comment %{version} meego-panel-pasteboard.src:3: W: macro-in-comment %{name} meego-panel-pasteboard.src:3: W: macro-in-comment %{version} => harmless, but inconsistent: sometimes meego-panel-pasteboard is replaced with %{name}, sometimes not meego-panel-pasteboard.src: W: no-buildroot-tag => ignore; MeeGo only targeting recent Fedora versions meego-panel-pasteboard.src: W: invalid-url Source0: meego-panel-pasteboard-0.0.8.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 6 warnings. blame upstream :) hopefully soon we can use VCS URLs as source *** DONE on x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** DONE Use %find_lang to handle locale files ** TODO Build [2/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2549253 *** DONE BRs complete *** FAIL Directory ownership Nobody owns %{_datadir}/mutter-meego/panels -- should mutter-meego own it? ** DONE Spec inspection [9/9] *** N/A ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section note: %clean section can be removed on F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** DONE Documentation [2/2] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential *** N/A Development ** N/A Desktop file validation ** N/A [[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]]
(In reply to comment #1) > Two things to fix: > - license should probably be GPLv2+ Fixed locally, can upload a new copy if deemed necessary. > - nobody owns the panels directory. mutter-meego should probably do this Fixed in mutter-meego-0.76.5-4.fc15
In which case the review is complete. On to the next component...
New Package GIT Request ======================= Package Name: meego-panel-pasteboard Short Description: MeeGo Panel for Paste Board Owners: pbrobinson Branches: F-14 InitialCC:
Git done (by process-git-requests).
build in rawhide. Thanks for the review.