SPEC: http://pbrobinson.fedorapeople.org/meego-panel-people.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-people-0.2.3-1.fc14.src.rpm Description: The Meego panel for managing and contacting people. Original Review: https://bugzilla.redhat.com/show_bug.cgi?id=518449
Taking this for review. rpmlint output (source): [adamw@adam SRPMS]$ rpmlint meego-panel-people-0.2.3-1.fc14.src.rpm meego-panel-people.src:3: W: macro-in-comment %{version} meego-panel-people.src:3: W: macro-in-comment %{version} meego-panel-people.src:3: W: macro-in-comment %{name} meego-panel-people.src:3: W: macro-in-comment %{version} meego-panel-people.src: W: no-buildroot-tag meego-panel-people.src: W: invalid-url Source0: meego-panel-people-0.2.3.tar.bz2 the macro-in-comment are fine. Invalid URL is also fine since the tarball is generated from git and the source commented, I guess - I take it upstream doesn't provide tarballs? No-buildroot-tag is fine as long as we're not expecting this to be taken into EPEL for RH5 or something, which I doubt would be appropriate/possible. "MUST: The License field in the package spec file must match the actual license." The license is not actually LGPLv2+ as the spec states; it's LGPLv2 . All the source headers state "you can redistribute it and/or modify it under the terms and conditions of the GNU Lesser General Public License, version 2.1, as published by the Free Software Foundation." , not "version 2.1 or later". Please change the license field to LGPLv2 . All other MUST items are okay. SHOULD: The reviewer should test that the package builds in mock. [27] SHOULD: The package should compile and build into binary rpms on all supported architectures. [28] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. I'm not able to test these currently due to Rawhide mirror borkage: Error Downloading Packages: telepathy-glib-0.13.6-1.fc15.x86_64: failure: Packages/telepathy-glib-0.13.6-1.fc15.x86_64.rpm from fedora: [Errno 256] No more mirrors to try. telepathy-glib-devel-0.13.6-1.fc15.x86_64: failure: Packages/telepathy-glib-devel-0.13.6-1.fc15.x86_64.rpm from fedora: [Errno 256] No more mirrors to try. telepathy-glib-vala-0.13.6-1.fc15.x86_64: failure: Packages/telepathy-glib-vala-0.13.6-1.fc15.x86_64.rpm from fedora: [Errno 256] No more mirrors to try. Even if I could test the build it's not practically possible to test functionality as present as this package is just part of the entire Meego environment, which is still under construction. As this is simply a rename request and Peter's fairly reliable, I'll trust him. :) I'll approve this once you submit an updated spec/src with the license field fixed.
Updated. Spec same location as above. SRPM: http://pbrobinson.fedorapeople.org/meego-panel-people-0.2.3-2.fc14.src.rpm
Great. I was now able to build it successfully and there's no errors or warnings in the binary rpmlint output. so, the review is approved, thanks!
Thanks for the review! New Package GIT Request ======================= Package Name: meego-panel-people Short Description: The Meego panel for managing and contacting people. Owners: pbrobinson Branches: F-14 InitialCC:
Git done (by process-git-requests).
Built and in rawhide. Thanks for the review