SPEC: http://pbrobinson.fedorapeople.org/meego-panel-status.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-status-0.2.4-1.fc14.src.rpm Description: The Meego panel for managing of social networks and your current status. This includes tweeting on twitter and updating of MySpace, FaceBook and you IM status. Original Review: https://bugzilla.redhat.com/show_bug.cgi?id=518450
note: fixed incorrect summary
The MD5sums do not match -- it appears that the files in your tarball are not sorted in alphabetical order, while the files I generated from git --archive are. Odd.
*** Bug 638060 has been marked as a duplicate of this bug. ***
meego-panel-status does not Obsoletes: and Provides: the old package: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages Are we providing an upgrade path from Moblin to Meego, or is that impossible?
(In reply to comment #4) > meego-panel-status does not Obsoletes: and Provides: the old package: SRPM: fixed here http://pbrobinson.fedorapeople.org/meego-panel-status-0.2.4-2.fc15.src.rpm > Are we providing an upgrade path from Moblin to Meego, or is that impossible? In terms of yum upgrade it should all work fine and most things should be migrated across.
mas: ping? I can take this over if you're short on cycles.
resetting to no one, Michel feel free to grab it again if you have the time.
Some build issues here. Trying to build in mock in Rawhide gives: configure: error: Package requirements (dbus-glib-1 clutter-x11-1.0 >= 1.0.0 clutter-gtk-0.10 libsocialweb-client >= 0.25.3 mx-1.0 >= 0.9.0 champlain-0.6 geoclue gconf-2.0) were not met: No package 'clutter-gtk-0.10' found No package 'champlain-0.6' found Rawhide clutter-gtk provides clutter-gtk-1.0 (not 0.10) and Rawhide champlain provides champlain-0.8 . I expect it'd build on F14 so this doesn't technically block the review, but since we're targeting F15 with the Meego stuff, it'd probably be best to grab some newer upstream code or something which can work with the newer clutter-gtk and champlain in Rawhide, if that's possible. Aside from the above, this looks good.
Fixed. SPEC: http://pbrobinson.fedorapeople.org/meego-panel-status.spec SRPM: http://pbrobinson.fedorapeople.org/meego-panel-status-0.2.6-1.fc15.src.rpm
thanks. looking good: it builds, the resulting packages are sane. Just the usual rpmlint warnings due to packaging a snapshot: meego-panel-status.src:3: W: macro-in-comment %{version} meego-panel-status.src:3: W: macro-in-comment %{version} meego-panel-status.src:3: W: macro-in-comment %{name} meego-panel-status.src:3: W: macro-in-comment %{version} meego-panel-status.src: W: invalid-url Source0: meego-panel-status-0.2.6.tar.bz2 meego-panel-status-devel.x86_64: W: no-documentation the no-documentation is okay as the only doc is the license, and -devel depends on the main package, which has the license. all the MUST review items pass. review approved.
Adam thanks again for the review. New Package GIT Request ======================= Package Name: meego-panel-status Short Description: MeeGo Panel for Social Network Status Owners: pbrobinson Branches: F-14 InitialCC:
Git done (by process-git-requests).
Built in rawhide