Spec URL: http://mifo.sk/RPMS/rubygem-open4.spec SRPM URL: http://mifo.sk/RPMS/rubygem-open4-1.0.1-1.fc13.src.rpm Description: Open child process with handles on pid, stdin, stdout, and stderr. Manage child processes and their IO handles easily.
i will take this review.
Hello, Jozef: As far as I checked FAS (Fedora Account System), it seems that you are not sponsored and are not in packager group. The person who is going to formally review review requests must be packager group. Would you tell me if you are sponsored? http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
MUST: rpmlint must be run on every package. The output should be posted in the review. rpmlint rubygem-open4-1.0.1-1.fc13.src.rpm rubygem-open4.src: W: spelling-error %description -l en_US pid -> peed, dip, pud rubygem-open4.src: W: spelling-error %description -l en_US stdin -> stein, stain, stdio rubygem-open4.src: W: spelling-error %description -l en_US stdout -> stout, std out, std-out rubygem-open4.src: W: spelling-error %description -l en_US stderr -> std err, std-err, stander rubygem-open4.src: W: no-buildroot-tag 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [OK] Each Ruby package MUST indicate the Ruby ABI version it depends on with a line like: Requires: ruby(abi) = 1.8 [OK - this MUST condition is written via macro in this spec file] Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname is the name from the Gem's specification. %global gemname open4 Name: rubygem-%{gemname} [OK] The Source of the package MUST be the full URL to the released Gem archive URL: http://github.com/ahoward/open4/tree/master Source0: http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem [OK] The version of the package MUST be the Gem's version Version: 1.0.1 [OK] The package MUST have a Requires and a BuildRequires on rubygems %global rubyabi 1.8 Requires: ruby(abi) = %{rubyabi} Requires: rubygems BuildRequires: rubygems [OK] The Gem MUST be installed into %{gemdir} defined as: %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [OK] If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch BuildArch: noarch [OK] The package MUST own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [OK] The install SHOULD be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} [OK] Note: At the end of %description is '.' character and i'm not sure if it's OK.
Yes i checked this wiki page before, so i've written unformally review to this package, and now i hope that somebody will add me to Fedora Packager Group. And of course i can tell you if i will have sponsoring. (In reply to comment #2) > Hello, Jozef: > > As far as I checked FAS (Fedora Account System), it seems > that you are not sponsored and are not in packager group. > The person who is going to formally review review requests > must be packager group. Would you tell me if you are sponsored? > > http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored
I will be sponsoring Jozef, taking over the review.
* The dot at the end of the description is OK, we avoid it only in Summary * Use %doc under your %files to specify documentation files The review from Jozef looks sane. Package approved.
(In reply to comment #6) > * The dot at the end of the description is OK, we avoid it only in Summary > * Use %doc under your %files to specify documentation files Could you please point me out, which files you mean ? I throught that there is no need to mark files under -doc sub package with %doc. > > The review from Jozef looks sane. Package approved.
Anyway thank you all for a review :-) New Package SCM Request ======================= Package Name: rubygem-open4 Short Description: Manage child processes and their IO handles easily Owners: mfojtik Branches: f12 f13 f14
Git done (by process-git-requests).
rubygem-open4-1.0.1-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-open4-1.0.1-1.fc13
rubygem-open4-1.0.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-open4-1.0.1-1.fc14
rubygem-open4-1.0.1-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/rubygem-open4-1.0.1-1.fc12
rubygem-open4-1.0.1-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-open4'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-open4-1.0.1-1.fc14
rubygem-open4-1.0.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-open4-1.0.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-open4-1.0.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
*** Bug 708990 has been marked as a duplicate of this bug. ***
Package Change Request ====================== Package Name: rubygem-open4 New Branches: epel7 Owners: tdawson