Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 647259

Summary: [Emulex 5.6 bug] Update be2net to version 2.102.512r
Product: Red Hat Enterprise Linux 5 Reporter: Subbu Seetharaman <subbu.seetharaman>
Component: kernelAssignee: Ivan Vecera <ivecera>
Status: CLOSED ERRATA QA Contact: chen yuwen <yuchen>
Severity: high Docs Contact:
Priority: high    
Version: 5.6CC: agospoda, andriusb, bdonahue, bugproxy, bzeranski, cward, dhoward, james.smart, jfeeney, jjarvis, karen.skweres, laurie.barry, ltroan, martinez, narayanan_d, nobody+PNT0273897, noboru.obata.ar, plyons, sandy.garza, sbest, sean.murphy, seiji.aguchi.tr, subbu.seetharaman, tyasui, vaios.papadimitriou, wenxiong, wwlinuxengineering, yuchen
Target Milestone: rcKeywords: OtherQA
Target Release: 5.6   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 630680 Environment:
Last Closed: 2011-01-13 21:58:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 568388, 630680    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch
none
Recent fixes to be2net none

Description Subbu Seetharaman 2010-10-27 17:41:55 UTC 
+++ This bug was initially created as a clone of Bug #630680 +++

Patch covers the following upstream changes :

be2net: Fix CSO for UDP packets
be2net: Call netif_carier_off() after register_netdev()
be2net: Schedule/Destroy worker thread in probe()/remove() rather than open()/close()

The first two are already applied to net tree.  The third one is already
submitted to netdev and yet to be applied.

Subbu
Comment 1 Andrius Benokraitis 2010-10-27 18:06:08 UTC 
These all look like bug fixes (no features). Proposing for post-Beta 5.6 inclusion.
Comment 2 Ivan Vecera 2010-11-02 17:12:52 UTC 
Created attachment 457232 [details]
Proposed patch

Subbu, I have backported the mentioned commits and attached the final patch. Could you please review it?
Comment 3 Subbu Seetharaman 2010-11-09 17:06:29 UTC 
Created attachment 459191 [details]
Recent fixes to be2net

Ivan,

Your patch matches with what I had prepared except for the driver version number change.  I thought I had attached the patch when I cloned the bug.  I am attaching it now.  Please use this instead if you can since I would like update the version number also.
Comment 4 Ivan Vecera 2010-11-09 17:44:37 UTC 
Thanks Subbu, of course I forgot version number change :-)
Comment 5 RHEL Program Management 2010-11-09 17:59:28 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 8 Jarod Wilson 2010-11-23 17:05:42 UTC 
in kernel-2.6.18-233.el5
You can download this test kernel (or newer) from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.
Comment 10 chen yuwen 2010-11-30 10:44:10 UTC 
reproduced on RHEL5.6-Server-20101119.0 with kernel 2.6.18-232.el5.

# modinfo be2net
filename:       /lib/modules/2.6.18-232.el5/kernel/drivers/net/benet/be2net.ko
license:        GPL
author:         ServerEngines Corporation
description:    ServerEngines BladeEngine 10Gbps NIC Driver 2.102.453r
version:        2.102.453r
...

verified on kernel 2.6.18-233.el5.

# modinfo be2net
filename:       /lib/modules/2.6.18-233.el5/kernel/drivers/net/benet/be2net.ko
license:        GPL
author:         ServerEngines Corporation
description:    ServerEngines BladeEngine 10Gbps NIC Driver 2.102.512r
version:        2.102.512r
...
Comment 12 errata-xmlrpc 2011-01-13 21:58:24 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html