Spec URL: http://ajax.fedorapeople.org/wayland/wayland.spec SRPM URL: http://ajax.fedorapeople.org/wayland/wayland-0.1-0.1.20101111.fc13.src.rpm Description: Wayland is a compositing system for Linux. This packaging includes the client and server libraries and the demo compositor. The sample clients are not yet packaged as they rely on cairo-gl support, which we do not build yet.
I'll review it
Koji scratch build for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2598962
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable - rpmlint is NOT silent work ~/Desktop: rpmlint libwayland-* wayland-* libwayland-client.x86_64: W: spelling-error Summary(en_US) wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-client.x86_64: W: summary-not-capitalized C wayland client library ^^^ Should be fixed (easyfix). libwayland-client.x86_64: W: spelling-error %description -l en_US wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-client.x86_64: W: shared-lib-calls-exit /usr/lib64/libwayland-client.so.0.0.0 exit.5 ^^^ Should be reported upstream. libwayland-client.x86_64: W: no-documentation ^^^ May be omitted libwayland-client.x86_64: E: library-without-ldconfig-postin /usr/lib64/libwayland-client.so.0.0.0 libwayland-client.x86_64: E: library-without-ldconfig-postun /usr/lib64/libwayland-client.so.0.0.0 ^^^ MUST be fixed. libwayland-client-devel.x86_64: W: spelling-error Summary(en_US) symlinks -> sym links, sym-links, slinks libwayland-client-devel.x86_64: W: spelling-error Summary(en_US) wayland -> Wayland, waylaid, way land libwayland-client-devel.x86_64: W: spelling-error %description -l en_US symlinks -> sym links, sym-links, slinks libwayland-client-devel.x86_64: W: spelling-error %description -l en_US wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-client-devel.x86_64: W: no-documentation ^^^ May be omitted libwayland-server.x86_64: W: spelling-error Summary(en_US) wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-server.x86_64: W: summary-not-capitalized C wayland server library ^^^ Should be fixed libwayland-server.x86_64: W: spelling-error %description -l en_US wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-server.x86_64: W: no-documentation ^^^ May be omitted. libwayland-server.x86_64: E: library-without-ldconfig-postin /usr/lib64/libwayland-server.so.0.0.0 libwayland-server.x86_64: E: library-without-ldconfig-postun /usr/lib64/libwayland-server.so.0.0.0 ^^^ MUST be fixed. libwayland-server-devel.x86_64: W: no-dependency-on libwayland-server/libwayland-server-libs/liblibwayland-server ^^^ MUST be fixed libwayland-server-devel.x86_64: W: spelling-error Summary(en_US) symlinks -> sym links, sym-links, slinks libwayland-server-devel.x86_64: W: spelling-error Summary(en_US) wayland -> Wayland, waylaid, way land libwayland-server-devel.x86_64: W: spelling-error %description -l en_US symlinks -> sym links, sym-links, slinks libwayland-server-devel.x86_64: W: spelling-error %description -l en_US wayland -> Wayland, waylaid, way land ^^^ false positive libwayland-server-devel.x86_64: W: no-documentation ^^^ May be omitted wayland.src: W: name-repeated-in-summary C Wayland ^^^ May be either ignored or fixed - feel free to decide by yourself. After reading description I still don't have strong opinion here. wayland.src: W: spelling-error %description -l en_US modesetting -> mode setting, mode-setting, typesetting wayland.src: W: spelling-error %description -l en_US evdev -> evade, evident, evidence wayland.src: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen ^^^ false positive wayland.src: W: no-buildroot-tag ^^^ Ok for F-15. wayland.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 17, tab: line 3) ^^^ Cosmetic. Should be fixed however this is not a blocker. wayland.src: W: invalid-url Source0: wayland-20101111.tar.bz2 ^^^ OK for SCM snapshots. wayland.x86_64: W: name-repeated-in-summary C Wayland ^^^ See similar message above. wayland.x86_64: W: spelling-error %description -l en_US modesetting -> mode setting, mode-setting, typesetting wayland.x86_64: W: spelling-error %description -l en_US evdev -> evade, evident, evidence wayland.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen, full-screen, firescreen ^^^ false positive wayland.x86_64: W: non-conffile-in-etc /etc/udev/70-wayland.rules ^^^ OK for udev-rules (they are not intended for changing by end-user). wayland.x86_64: W: no-manual-page-for-binary compositor wayland-common.x86_64: W: no-documentation wayland-devel.x86_64: W: no-documentation ^^^ Ok for now. 9 packages and 0 specfiles checked; 4 errors, 35 warnings. work ~/Desktop: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. - The License field in the package spec file DOES NOT matche the actual license. * The compositor sub-package is licensed under GPLv2 or later (see its sources) * The wayland/scanner.c is licensed under GPLv2 or later. * Thge contents of contents folder is licensed under CC-BY-SA and the file with the text of this license ( contents/COPYING ) must be included as %doc + The spec file is written in American English. + The spec file for the package is legible. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. - Some sub-packages stores shared library files in some of the dynamic linker's default paths, so they MUST call ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. + Header files are stored in a -devel package. 0 No static libraries. 0 No pkgconfig(.pc) files. + The library file(s) that end in .so (without suffix) is(are) stored in a -devel package. + Although it's stated in packaging Guildelines that the -devel sub-packages MUST require the base package using a fully versioned dependency, it's pretty clear that it's not necessary in this particular case (they should require only main *-devel sub-package and their corresponding non-devel sub-package (e.g. libwayland-client-devel must require only libwayland-client and wayland-devel). + The package does NOT contain any .la libtool archives. +/- The package does NOT include a %{name}.desktop file but I'm not sure that this package is intended to be started from traditional desktop. Could someone clarify this? + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. OK, so here is a list of items in the TODO list: * Properly call ldconfig where necessary * Fix licensing * Fix minor cosmetic issues in the spec-file
> * The wayland/scanner.c is licensed under GPLv2 or later. The scanner isn't an installed application, it never escapes the buildroot. I'm pretty sure we don't require licensing of components like that to be reflected in the License tag. But, since the compositor ends up in the base package, the srpm should appear to be GPLv2+ now. > +/- The package does NOT include a %{name}.desktop file but I'm not sure that > this package is intended to be started from traditional desktop. Could someone > clarify this? It's really not. Same reason that the X server doesn't have a desktop file. Updated spec and srpm in the same place as before.
Ok, good. I can't see any other issues here, so this package is APPROVED.
New Package SCM Request ======================= Package Name: wayland Short Description: the wayland compositing system Owners: ajax Branches: F14 InitialCC:
(Re-adding fedora-review+, unintentionally removed.)
Git done (by process-git-requests).
Imported and built for rawhide, thanks.