Spec URL: http://salimma.fedorapeople.org/specs/gnome/ease.spec SRPM URL: http://salimma.fedorapeople.org/specs/gnome/ease-0.4-1.fc14.src.rpm Description: Ease is a modern desktop presentation application for GNOME, with Clutter-based visuals. With a simple design, Ease is painless to use. It is intended to integrate well into your current GNOME-based desktop.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2605434 rpmlint: SRPM: ease.src:53: E: hardcoded-library-path in /usr/lib ==> this is due to the rpath fix, adding /lib64 and /usr/lib64 to the system libdirs so that libtool does not add RPATHs for /usr/lib64 in the linked binaries ease.src: W: no-cleaning-of-buildroot %clean ease.src: W: no-buildroot-tag ease.src: W: no-%clean-section ==> only targeting recent Fedora releases 1 packages and 0 specfiles checked; 1 errors, 3 warnings. ease-*.x86_64.rpm: ease.x86_64: W: no-manual-page-for-binary ease ease-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. note: rpmlint-ing the installed RPM results in a lot of undefined-non-weak-symbol warnings; this might shed some light into the issue: http://sourceware.org/ml/libc-alpha/2003-05/msg00034.html
I'm taking a slightly unusual approach to specifying BuildRequires:, specifying pkgconfig modules instead of the usual -devel package names. This aligns better with configure.ac (so one can easily verify that the two are in sync), and build problems due to API changes would abort the build earlier (during root FS setup rather than during the rebuild phase).
oh, p.s. this does not currently build on Rawhide -- Vala'd need to be updated first for some of the updated bindings (clutter-gtk-1.0 and rest-0.7)
I will do the review by this weekend.
Thanks! FYI -- I've tested basic functionality on a Fedora 14 machine with an Intel card and it works fine (it won't work with the open-source radeon or nouveau drivers, even with the experimental Mesa DRI drivers, but would probably work with the binary nVidia drivers -- but those have issues on my workstation's older nVidia card).
I see some .pc files in -devel subpackage, Don't they require 'pkgconfig' ?
(In reply to comment #6) > I see some .pc files in -devel subpackage, Don't they require 'pkgconfig' ? Hi Arun, That's handled automatically by RPM: $ rpm -qp --requires ease-devel-0.4-1.fc14.x86_64.rpm | grep pkg-config /usr/bin/pkg-config $ rpm -qf /usr/bin/pkg-config pkgconfig-0.25-2.fc14.x86_64 Unfortunately the Koji build results have been garbage collected by now; you can check the rebuild I just made here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2664560 Just in case, though, the Koji-built RPMs are now cached in http://salimma.fedorapeople.org/specs/gnome/ as well. Please check them if the Koji builds are no longer accessible.
[+] OK [X] NOT OKAY [-] NA [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [zer0c00l@gnubox SOURCES]$ md5sum ~/Downloads/ease-0.4.tar.bz2 9134b74a2ff3701b62d08f5b4d954232 /home/zer0c00l/Downloads/ease-0.4.tar.bz2 -- done [-] Package needs ExcludeArch [+] BuildRequires correct [+] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [-] Package has a correct %clean section. [-] Package has correct buildroot [+] Package is code or permissible content. [-] Doc subpackage needed/used. [-] Packages %doc files don't affect runtime. [+] Headers/static libs in -devel subpackage. [+] Spec has needed ldconfig in post and postun [X] .pc files in -devel subpackage/requires pkgconfig [+] .so files in -devel subpackage. [+] -devel package Requires: %{name} = %{version}-%{release} [+] .la files are removed. [+] Package is a GUI app and has a .desktop file [+] Package compiles and builds on at least one arch. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [+] No rpmlint output : ignorable [zer0c00l@gnubox i686]$ rpmlint ease-0.4-1.fc13.i686.rpm ease.i686: W: no-manual-page-for-binary ease 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [zer0c00l@gnubox i686]$ rpmlint ease-devel-0.4-1.fc13.i686.rpm ease-devel.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [zer0c00l@gnubox i686]$ rpmlint ~/rpmbuild/SRPMS/ease-0.4-1.fc13.src.rpm ease.src:53: E: hardcoded-library-path in /usr/lib ease.src: W: no-cleaning-of-buildroot %clean ease.src: W: no-buildroot-tag ease.src: W: no-%clean-section Note: hardcoded-library-path in /usr/lib @ Line 53. Where the line is "sed -i 's|/lib /usr/lib|/lib /usr/lib /lib64 /usr/lib64|' libtool". It removes rpath. Not an error. SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [+] check for outstanding bugs on package. (For core merge reviews) XXX APPROVED XXX
Thanks! New Package SCM Request ======================= Package Name: ease Short Description: GNOME desktop presentation application Owners: salimma Branches: f13 f14 InitialCC:
Git done (by process-git-requests).
ease-0.4-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ease-0.4-1.fc13
ease-0.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ease-0.4-1.fc14
ease-0.4-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ease'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ease-0.4-1.fc14
ease-0.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
ease-0.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.