I'll file one bug instead of the seven I was tempted to. The new beaker nag mail triggers on system states I was assured wouldn't be nagged about. Examples: [Beaker Reminder]: System musashi.usersys.redhat.com This is my personal laptop. Owner: mbrodeur, User: mbrodeur, not shared, SECRET, Automated (just fixed that part) [Beaker Reminder]: System intel-s6e62-03.lab.bos.redhat.com Broken system that we're still working on. Owner: mbrodeur, User: mbrodeur, Shared, Broken [Beaker Reminder]: System rhts-nfs-02.rhts.eng.bos.redhat.com Eng-ops server. Owner: mbrodeur, User: mbrodeur, not shared, Automated?! (fixed) [Beaker Reminder]: System db01.db.eng.bos.redhat.com [Beaker Reminder]: System db02.db.eng.bos.redhat.com Eng-ops server. Owner: mbrodeur, User: mbrodeur, not shared, SECRET, Automated/Broken [Beaker Reminder]: System alpo.boston.devel.redhat.com [Beaker Reminder]: System innova.boston.devel.redhat.com Eng-ops servers. Owner: mbrodeur, User: mbrodeur, not shared, SECRET, Automated (fixed) So, at least two problems. The nag mail shouldn't hit for systems where the user is also the owner. It probably also shouldn't go to non-shared systems. There's also the issue of systems previously marked broken becoming Automated, but that's a separate problem.
*** Bug 654303 has been marked as a duplicate of this bug. ***
A the moment the only filtering that happens is based on whether or not the system was reserved via the web UI, and the amount of time it's been taken for. From what I can tell that's the way it's always been. We can easily change that to exclude 1) Shared systems 2) user == owner
(In reply to comment #2) > A the moment the only filtering that happens is based on whether or not the > system was reserved via the web UI, and the amount of time it's been taken for. > From what I can tell that's the way it's always been. > > We can easily change that to exclude > > 1) Shared systems I mean non shared systems of course > 2) user == owner
http://git.fedorahosted.org/git/?p=beaker.git;a=blobdiff;f=Server/bkr/server/tools/nag_email.py;h=736897588e2a06919d3ce433a1ac5199482ea7f5;hp=c87407cca6b1efcd6483239d4c7e101b817764a5;hb=c52e48e8500c931129222af3f18ec6b3eee60770;hpb=610038ad875c83db456da9f6a260fbb0d5d0e82f Bill, can you take a look ?
*** Bug 654224 has been marked as a duplicate of this bug. ***