Bug 656010 - Review Request: libsrtp - An implementation of the Secure Real-time Transport Protocol (SRTP)
Summary: Review Request: libsrtp - An implementation of the Secure Real-time Transport...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dmitrij S. Kryzhevich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-11-22 21:01 UTC by Tom "spot" Callaway
Modified: 2014-10-20 19:45 UTC (History)
4 users (show)

Fixed In Version: libsrtp-1.4.4-1.20101004cvs.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-12-17 08:23:43 UTC
kryzhev: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2010-11-22 21:01:31 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/new/libsrtp.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/libsrtp-1.4.4-1.20101004cvs.fc14.src.rpm
Description: 
This package provides an implementation of the Secure Real-time
Transport Protocol (SRTP), the Universal Security Transform (UST), and
a supporting cryptographic kernel.

****
Packager's Note: This is a new dependency for libjingle.

Comment 1 Dmitrij S. Kryzhevich 2010-12-03 07:20:20 UTC
rpmlint is not silent.

libsrtp.src: W: no-cleaning-of-buildroot %clean
libsrtp.src: W: no-buildroot-tag
libsrtp.src: W: no-%clean-section
libsrtp.src: W: invalid-url Source0: srtp-1.4.4-20101004cvs.tar.bz2
libsrtp.x86_64: W: shared-lib-calls-exit /usr/lib64/libsrtp.so.0.0.0 exit@GLIBC_2.2.5
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Exit call is not good. Could you provide any reasons why it might be leaved as is?

Is there any way to specify the revision for csv checkout in spec?

* The package named according to the Package Naming Guidelines.
* The spec file name match the base package %{name}. 
* The package meets the Packaging Guidelines.
* The package is licensed with a Fedora approved license.
* The License field in the package spec file matchs the actual license.
* File, containing the text of the license(s) for the package is included in %doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package match the upstream source. MARK: md5sum on provided .tar.bz2 and obtained .tar.bz2 are MISMATCHED, but the sources are EQUAL.
* The package successfully compiles and builds into binary rpms on x86_64 F14.
* All build dependencies are listed in BuildRequires.
* There are no locales.
* Binary RPM package which stores shared library files calls ldconfig in %post and %postun.
* Packages do not bundle copies of system libraries.
* A package owns all directories that it creates.
* There are no files, listed more than once in the spec file's %files listings.
* Permissions on files are set properly.
* The package contains code, or permissable content.
* There is no large documentation.
* Header files are in a -devel package.
* There are no static libraries.
* Library files that end in .so (without suffix) is in a -devel package.
* Devel packages requires the base package.
* Packages doed not contain any .la libtool archives.
* All filenames in rpm packages are valid UTF-8.

All is need are the answers on two above questions.

Comment 2 Tom "spot" Callaway 2010-12-03 15:59:25 UTC
Honestly, I'm not sure how to get any sort of sane revision for the tree from cvs. If you know how, I'd be happy to add it.

The exit() call is in crypto_kernel_status (in crypto/kernel/crypto_kernel.c)

  /* for each cipher type, describe and test */
  while(ctype != NULL) {
    printf("cipher: %s\n", ctype->cipher_type->description);
    printf("  instance count: %d\n", ctype->cipher_type->ref_count);
    printf("  self-test: ");
    status = cipher_type_self_test(ctype->cipher_type);
    if (status) {
      printf("failed with error code %d\n", status);
      exit(status);
    }
    printf("passed\n");
    ctype = ctype->next;
  }

Unfortunately, it is not trivial to remove that exit(), so I'm inclined to just leave it in.

Comment 3 Jason Tibbitts 2010-12-03 16:06:55 UTC
With CVS all you have is a date, or a tag if upstream has made one.  There is no concept analogous to SVN's revision number or git's commit hash.

Comment 4 Dmitrij S. Kryzhevich 2010-12-04 09:41:51 UTC
>Unfortunately, it is not trivial to remove that exit()

Ok. What about ping upstream?
Not a blocker. 

>With CVS all you have is a date

Yes, -D, found it. May be, just may be, it would be nice to be sure there is _this_ version that in the package. Not a blocker.

APPROVED.

Comment 5 Tom "spot" Callaway 2010-12-06 15:02:51 UTC
New Package SCM Request
=======================
Package Name: libsrtp
Short Description: An implementation of the Secure Real-time Transport Protocol (SRTP)
Owners: spot jcollie
Branches: f13 f14 devel
InitialCC:

Comment 6 Jason Tibbitts 2010-12-06 16:00:31 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2010-12-06 17:48:13 UTC
libsrtp-1.4.4-1.20101004cvs.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc13

Comment 8 Fedora Update System 2010-12-06 17:48:21 UTC
libsrtp-1.4.4-1.20101004cvs.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc14

Comment 9 Fedora Update System 2010-12-07 20:08:22 UTC
libsrtp-1.4.4-1.20101004cvs.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libsrtp'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libsrtp-1.4.4-1.20101004cvs.fc13

Comment 10 Fedora Update System 2010-12-17 08:23:36 UTC
libsrtp-1.4.4-1.20101004cvs.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2010-12-17 08:43:31 UTC
libsrtp-1.4.4-1.20101004cvs.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Jeffrey C. Ollie 2011-01-24 20:23:06 UTC
Package Change Request
======================
Package Name: libsrtp
New Branches: el6
Owners: jcollie
InitialCC: 

Wanted for Asterisk SRTP support.

Comment 13 Jason Tibbitts 2011-01-24 21:46:43 UTC
Git done (by process-git-requests).

Comment 14 Jeffrey C. Ollie 2014-10-20 16:49:13 UTC
Package Change Request
======================
Package Name: libsrtp
New Branches: epel7
Owners: jcollie
InitialCC: 

For Asterisk SRTP support

Comment 15 Gwyn Ciesla 2014-10-20 19:45:26 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.